novox/hq
18
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request 'Developer and reviewer definitions: validate every manifest a change touches before handing back (issue 1585)' (#517) from agents/dev-validates-manifests into main

Browse Source
This commit was merged in pull request #517.
This commit is contained in:
mesh-tools
2026-11-05 00:44:47 +00:00
parent 6b8b6b08e3 749249466f
commit 331e570792
2 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.claude/agents/mesh-code-reviewer.md
+3
View File
@@ -29,6 +29,9 @@ against the records, never limits on what you check: a ruling that contradicts a
function where the repository is over budget, real sleeping; function where the repository is over budget, real sleeping;
- vet or tests that fail: run `go vet ./...`, `go vet -tags integration ./...` and `go test ./...` in every - vet or tests that fail: run `go vet ./...`, `go vet -tags integration ./...` and `go test ./...` in every
touched module, as the running checker places siblings. touched module, as the running checker places siblings.
- a change to any `module.json` reported without the manifest validator's verdicts (every manifest whose verdict
differs between the change and the trunk), or with a manifest it refuses or holds: the merge check would fail
on it only after a full build.
Anything else (hardening, a further case, a nicer form) is a note, never a round. Read only: no edits, no git Anything else (hardening, a further case, a nicer form) is a note, never a round. Read only: no edits, no git
write, no verb that writes, never ssh. Use a temporary directory under `/var/tmp`. write, no verb that writes, never ssh. Use a temporary directory under `/var/tmp`.
.claude/agents/mesh-developer.md
+9
View File
@@ -32,6 +32,15 @@ sleeping. Run `go vet ./...`, `go vet -tags integration ./...` and `go test ./..
the running checker places siblings (playbook 07). Use a temporary directory under `/var/tmp` (TMPDIR). Before you the running checker places siblings (playbook 07). Use a temporary directory under `/var/tmp` (TMPDIR). Before you
report a head, also run the repository's own checks whole (in the catalog every `checks/*`): a head that passes its report a head, also run the repository's own checks whole (in the catalog every `checks/*`): a head that passes its
modules' tests can still break a check of the whole repository, such as a committed binary or an unannounced state. modules' tests can still break a check of the whole repository, such as a committed binary or an unannounced state.
When the change touches any `module.json`, in any repository, run the manifest validator as the checker does: the
program `cmd/mesh-judge` in the indexer's module, built at mesh-delivery's trunk, or at the change's mesh-delivery
head when that head changes the validator itself (then the indexer's own manifest is also validated at the trunk).
Give it raw manifests, not digests: the trunk's, with the change's laid over them, as the two cases `change` and
`trunk` the checker's `judgeRequest` names, with the predefined key list when the change alters it. The merge check
fails a changed manifest the validator refuses or holds, and also an unchanged one in which the change causes a
problem the trunk case lacks; it says so only after a full build, and no module's unit tests run the validator.
Report every manifest whose verdict differs between the two cases, with your heads. The reviewer asks for those
verdicts, and a head reported without them is not reviewed.
Start no agents of your own: the lead decides who works on what. Start no agents of your own: the lead decides who works on what.
**Stop at about two thirds of your context.** Commit what is done, write a section under your agent label at the **Stop at about two thirds of your context.** Commit what is done, write a section under your agent label at the