From 39f7ae7203bedd4fea4e53ef9be738925e71eb03 Mon Sep 17 00:00:00 2001 From: jochen Date: Mon, 16 Nov 2026 13:53:30 +0100 Subject: [PATCH] Reviewers: a hard-coded value and a file written for another module are findings (principles 11 and 12) --- .claude/agents/mesh-code-reviewer.md | 4 ++++ .claude/agents/review-seams-and-tools.md | 3 +++ 2 files changed, 7 insertions(+) diff --git a/.claude/agents/mesh-code-reviewer.md b/.claude/agents/mesh-code-reviewer.md index fca02b50..cf287df6 100644 --- a/.claude/agents/mesh-code-reviewer.md +++ b/.claude/agents/mesh-code-reviewer.md @@ -26,6 +26,10 @@ questions are. - an interaction the design does not place that is not a mesh path: one module naming another, reading another's internals or being special-cased in another part; a module's name in shared code; state only in memory; a poll or a timer where an event exists; +- a value written into the code that can differ between machines, modules or over time (a port, a path, a bound, a + cap, a name, a time) and is not a setting with a default (principle 11); name the setting it should be, eagerly; +- a module that writes another module's file or state, or anything in another module's place, instead of giving it + through a provision or a contribution that module declares (principle 12); - an effect or a reader of the build map's `What exists today` whose fate the diff does not carry out (run its searches again on the reviewed tree), or one the search finds and the answer omits; - a test that does not fail without its change (check it by taking the change out in a copy), an acceptance diff --git a/.claude/agents/review-seams-and-tools.md b/.claude/agents/review-seams-and-tools.md index 76f71226..6897de87 100644 --- a/.claude/agents/review-seams-and-tools.md +++ b/.claude/agents/review-seams-and-tools.md @@ -25,6 +25,9 @@ write. What you judge: - Seams: where each piece of state lives on the bus (key-value bucket, stream, object store) and which module owns it; which seat, verb or event joins two parts; any link that is not NATS-native (a poll, a timer, HTTP between modules, a shared file, state only in memory); whether a form the manifest lacks is named with its cost (a mesh-sdk change rebuilds every module). +- Settings and ownership: every value that can differ between machines, modules or over time is a setting with a + default, never hard-coded (principle 11), and the design names it; no module writes another module's file or state: + what one module needs from another goes through a provision or a contribution that module declares (principle 12). - Tools: for every new piece of state a tool that reads it, and for every new behaviour a tool that steers it (do by hand, ask again, drop, repair, re-check), as the instruction tools-are-how-a-module-is-spoken-to says. Judge only whether the settled direction or design is complete and sound in your two architectural domains,