From 9f0b0215ae6a823aeba8c73a6942fc148c29f0c9 Mon Sep 17 00:00:00 2001 From: jochen Date: Wed, 21 Oct 2026 09:58:44 +0200 Subject: [PATCH] Playbook 08: check a module compiles with go vet, never go build in its folder (issue 1577) go build in a module's folder writes the program beside go.mod, and two such programs were committed on 2026-10-21, caught only by the review. --- 00-META/process/08-small-fixes.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/00-META/process/08-small-fixes.md b/00-META/process/08-small-fixes.md index a301281e..d0070bbb 100644 --- a/00-META/process/08-small-fixes.md +++ b/00-META/process/08-small-fixes.md @@ -37,6 +37,9 @@ one delivery**. Everything before the try is local and fast. test that fails today first, on an assertion about what the code does: a test that fails only because it does not compile has not failed first (playbook [07](07-feature-branches.md) step 1); make the change; keep `gofmt`, `go vet` and the repository's whole unit suite green before every commit (each test well under a second; never a merge check or a database locally: how-we-build ยง5, ADR 0391). + Check that it compiles with `go vet`, never `go build` in a module's folder: with one main package it writes the + program beside `go.mod`, and `git add -A` takes it (issue 1577: two 5-10 MB programs committed on 2026-10-21, + caught only by the review); read `git show --stat` before pushing. The tests are written from the acceptance criteria, at least one per criterion at its level, each citing the criterion it proves by its label (`/AC`, playbook 07 step 0 item 5). Commit, naming the issue. For a playbook or design edit, run the repository's own checks (in hq, `sh merge-check.sh`). Then push the branch and run `mesh-controller.try` on it, so the review reads the