From a17f5bba0574b056200d168db7bb97f5b09cf843 Mon Sep 17 00:00:00 2001 From: jochen Date: Sat, 21 Nov 2026 22:39:27 +0100 Subject: [PATCH] Design 47 H2: each prepare question names the lead's answer beside it (H-A-349, H-A-350) --- .../H2-the-delivery-systems-owed-work.md | 33 +++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/03-DESIGN/01-to-be/47-milestones/H2-the-delivery-systems-owed-work.md b/03-DESIGN/01-to-be/47-milestones/H2-the-delivery-systems-owed-work.md index a97c8884..d86a06f0 100644 --- a/03-DESIGN/01-to-be/47-milestones/H2-the-delivery-systems-owed-work.md +++ b/03-DESIGN/01-to-be/47-milestones/H2-the-delivery-systems-owed-work.md @@ -430,26 +430,32 @@ the preparer's, said as one. `accepts`; the runner puts every step on `accept.step`, `cmd/mesh-delivery-pipeline/asks.go:27`). Left to the builder: whether the kinds are renamed and split. Recommendation: keep the one kind `step` on each seat and read the line's kinds as the step the ask names, so no subject and no reader changes. + answered: H-A-349 DQ-1. - **DQ-2** (§777) The line rebuilds the `mesh-builds` stream empty through `nats_recreate`; the `mesh-wants` stream `SEAT_MESH_WANTS` holds 1,598 messages and 0 consumers as well (live, `nats.nats_streams`, 22:25 CET), and `mesh-builds`' 1,558 now. Left: the fate of `SEAT_MESH_WANTS`' messages. Recommendation: rebuild both empty on the same warrant, before the new builder and the new assigner start. + answered: H-A-349 DQ-2. - **DQ-3** (§782) The line names "mesh-sdk's wrappers around one bus handle" without naming them; mesh-sdk holds several (`process.Conn`'s state and stream calls, `stdio`'s `BusState` through the runtime, `views`). Recommendation: name the wrapper row 137 met twice, by package and type, in the line. + answered: H-A-349 DQ-3. - **DQ-4** (§777, §778) The runner's second put under `AgainID` with its bound key `ask2.` serves the build seats today (`internal/pipeline/asks.go:27-60`, `:134-160`); the line says the runner puts again only on a transport fault but gives `AgainID` and `ask2.` no fate. Recommendation: both go for every seat, by §777's rule. + answered: H-A-349 DQ-4. - **DQ-5** (§783, §820) Which delivery modules are foundation parts (ADR 0619 §1, ADR 0666 §4) that declare their stores in the old section, and which ask in `requires` by template, is not said; today the runner, the builder, the indexer and the assigner use the old sections (`mesh-delivery-pipeline/module.json:205-240`, `mesh-delivery-builder/module.json:120-140`) and the bridge uses `requires` (`mesh-delivery-forge-bridge/module.json:40-45`). Recommendation: the line lists the foundation parts by module. + answered: H-A-349 DQ-5. - **DQ-6** (§793) The work queue `publishes` (§820: work queue, 64 MiB, 7 days) names its subject and consumers per holder and class, but not whether the consumers are declared in the builder's `requires` or derived by the broker, and the move's message id `..` names no class while `builder_publish_first` puts an item again as `live` within the duplicates window. Recommendation: the builder declares the stream and its consumers in `requires`, and `builder_publish_first` puts under an id carrying the class. + answered: H-A-349 DQ-6. - **DQ-7** (§808, H-A-345) The vault's seat serves no write of a module's own secret, and its read `own` answers only the node-engine of a machine, sealed to the machine's key, so a forge module process can neither write nor read its token through `own` (`mesh-contracts` `identity-and-access/seats/mesh-vault/seat.json`, verbs `own`, `get`, `licence-put`; @@ -457,47 +463,58 @@ the preparer's, said as one. too. Recommendation: add to the vault's seat a two-step sealed write of a module's own secret modelled on `licence-put` (the module named by the caller's account, its newest generation kept), and read the token through `get`, sealed to the process's key; built in `mesh-catalog` `modules/mesh-vault` and `mesh-contracts`, before the forge module's §808 work. + answered: H-A-349 DQ-7. - **DQ-8** (§802) A mesh Go package that no module the indexer holds has published enters the fingerprint by the commit the gate's source names for its repository (`mesh-delivery` `internal/index/form.go:113-125`, design 47 G A-365), and the import form's versions are a holding module's published commit (`form.go:30-33`); the line does not say what such a package enters by under ADR 0499 §2. Recommendation: a package of the module's own repository enters by its directory's tree, as a directory replace does already (`form.go:39-41`); another repository's unpublished package leaves the module without a fingerprint until it is published, said as today's `NoPackageVersion`. + answered: H-A-349 DQ-8. - **DQ-9** (§815) The source-only registration has no module, while the state `registrations` is keyed `` and a registration requires `module`, `origin`, `path` and `branches` (`seats/mesh-catalog/seat.json` `defs.Registration`); the line names `repository` and one `branch`. Left: its key, its field names against `origin` and `branches`, and its history key. Recommendation: key `source..` in the same states, fields `origin`, `branches` (one), `policy`, `check`, so readers of registrations read one form. + answered: H-A-349 DQ-9. - **DQ-10** (§814, §820) The seat list as one object "in the indexer's objects, by digest" is a store §820's table does not hold: its objects entry, cap, key life and deleter. Recommendation: the indexer's objects `seat-lists`, 64 MiB, one object per digest, the indexer deleting every object but the newest two at each new list. + answered: H-A-349 DQ-10. - **DQ-11** (§813 (4)) The node-engine marks each rule it writes `mesh-host ` and recognises its own rules and stale ones by that mark (`mesh-host` `internal/firewall/firewall.go:415-427`, `:782`); the line's comment `derived scope <…>` gives the mark no fate. Recommendation: the scope words follow the mark in the one comment, so the reconciling keeps reading the mark. + answered: H-A-349 DQ-11. - **DQ-12** (§813 (1)) "A composition key" is not named: the state and key the holder of `mesh-wants` writes by compare-and-set (its `wants` `want..`, `compositions` `.`, or the node-engine's composed bucket), and `run`'s form: the node-engine contract already carries `run` as a string (`mesh-contracts` `go/seats/nodeengine/contract.go:1764`) while the line says a pipeline sequence. Recommendation: name the state and key, and keep the existing field `run` holding the sequence as a decimal string, so no form is raised. + answered: H-A-349 DQ-12. - **DQ-12b** (§813 (3)) `engine_composition_diff` is "the node-engine's tool", but the node-engine serves only the seat `node-engine`'s verbs and has no tools bundle (`mesh-host`: no `engine_` tool name in any file; live `ace/node-engine.*` are seat verbs). Recommendation: a read verb `composition-diff` on the seat `node-engine`, beside `composition`. + answered: H-A-349 DQ-12b. - **DQ-13** (§821) "The re-pin's" event is not named, and the runner's seat declares none for a re-pin today (`seats/mesh-pipeline-runner/seat.json` events). Recommendation: the line names it (`re-pinned`, carrying the pipeline, the mover and the revision). + answered: H-A-349 DQ-13. - **DQ-14** (§819) The starting counts by `go test -list` without and with `-tags integration` (top-level functions, 22:30 CET) differ from the line's: the indexer 167 unit and 6 integration (line: 170 and 6), the assigner 86 and 9 (87 and 9), the node-engine 1,715 and 11 (1,716 and 11); the runner 105 and 4 and the builder 167 and 18 agree. By the tag the NFS server module holds 0 integration and 51 unit, the package manager module 3 and 118, where the line's 51 and 121 are the build node's counts, which take untagged tests in. Recommendation: each pull request's check gives the starting count at its base, and the line keeps its figures as a guess said as one. + answered: H-A-349 DQ-14. - **DQ-15** (§776) The forge module is TypeScript; the line places `away` in mesh-sdk's seat error answer without saying whether mesh-sdk's TypeScript seat helpers carry it. Recommendation: they do, in the same commit. + answered: H-A-349 DQ-15. - **DQ-16** (§810) `class` is `core` "when it moves a core module of ADR 0282 §1"; the gate holds no list or field naming a module's class (`grep -rn -i "core\|class" --include='*.go' mesh-catalog/modules/mesh-delivery-gate/cmd` finds none). Left: where the gate reads it. Recommendation: the gate reads it from a setting `core-modules` (a list, default the delivery system's modules and the node-engine), so the self-check's probe and the gate read one list. + answered: H-A-349 DQ-16. ## Design meets code @@ -510,64 +527,80 @@ recommendation, said as one. `modules/mesh-grants/internal/buscompose/derived.go:86-110`, `:343-358`), and mesh-sdk keeps a second `buscompose` (`mesh-sdk` `go/buscompose/nats.go:96-98`). Live max age is 168 hours. Recommendation: the seat definition's accepts gain these settings, read by the one derivation in mesh-sdk's `buscompose`, which the grants part takes. + answered: H-A-350 DMC-1. - **DMC-2** (§776) *A part the line assumes built that is not.* mesh-sdk has no seat error answer: error kinds are each seat's own (`git`'s `ErrorKind`: `refused`, `not-found`, `failed`, `seats/git/seat.json`; `mesh-catalog` `modules/gitea/seat.ts:71`). Recommendation: add `away` to the error kinds of every seat the delivery parts call (`git` first), and mesh-sdk's kept call reads `away` as a transport fault by the answer's `error-kind`. + answered: H-A-350 DMC-2. - **DMC-3** (§796) *A form the code cannot take.* The `tags` answer is a list of strings (`seats/git/seat.json` `tags`); `commit` per tag makes each item an object, a form raised (§780) for every reader (`mesh-delivery-builder` `internal/versions/claim.go:213`, `mesh-sdk` `seatlist/bootstrap/git.json`). Recommendation: items become `{tag, commit}` with the seat's `form` 2, read tolerantly by §780. + answered: H-A-350 DMC-3. - **DMC-4** (§780) *A part placed where it is not.* The seat generator is `mesh-delivery`'s `modules/mesh-delivery-sdk/seatgen`, not mesh-sdk's; mesh-sdk's `seatdef` reads definitions only. Recommendation: build the tolerant decoders and the `form` check in `seatgen`, and regenerate every seat in `mesh-delivery` and `mesh-contracts`. + answered: H-A-350 DMC-4. - **DMC-5** (§802) *A part placed where it is not, and a form already built.* The one fingerprint function is the indexer's (`mesh-delivery-indexer/internal/fingerprint/fingerprint.go:1-5`: "the indexer's own, and nobody else's"; the builder reads what the indexer writes), not mesh-sdk's; and its tree input is already the directory's tree or the named paths (`internal/index/inputs.go:97-118`); the commit enters through DQ-8's packages. Recommendation: build §802 in the indexer's `fingerprint` and `form.go`, the builder taking nothing new but the release in one group. + answered: H-A-350 DMC-5. - **DMC-6** (§800) *A rule in code the line breaks.* `check-needs` is a marker file in a package's directory, kept "not a manifest field" on purpose (`mesh-catalog` `modules/mesh-build-go/cmd/mesh-build-go/digest.go:59-66`), read by `mesh-delivery-sdk` `steprun.AskNeeds`; the line makes it a manifest field of a Go artifact. Recommendation: the line holds: the manifest field replaces the marker file, whose fate (it goes, its readers moved) the line states. + answered: H-A-350 DMC-6. - **DMC-7** (§799) *A part placed where it is not.* The delay before a run ended `again` is offered again is the tool runner's `WorkBackoff` (5 s doubling to 10 minutes, `mesh-tools` `internal/bus/seat.go:71-79`, `:315`) or a bundle's own `NakWithDelay` (`seat_pull.go:193`); the line says "the tool runner settles the ask with a delay of 15 s ... 60 s", a build module's setting, built in the kit and the build modules. Recommendation: the build module passes its `again-delays` with its `again` (the bundle's delay), so the tool runner changes nothing; mesh-tools' T3 then drops. + answered: H-A-350 DMC-7. - **DMC-8** (§786, §789, §816) *Parts assumed built that are not.* The runner has no tools `runner_show`, `runner_cancel` or `runner_movers` (`mesh-delivery-pipeline/module.json`, 14 tools; the verbs `show` and `cancel` exist on the seat). Recommendation: `runner_show` and `runner_movers` are built in R8 as the tools table says; §816's `runner_cancel` reads as the seat verb `cancel`. + answered: H-A-350 DMC-8. - **DMC-9** (§814) *A part placed where it is not.* The validate step and `causedProblems` are the assigner's (`mesh-delivery-assigner/cmd/mesh-delivery-assigner/validatestep.go:124`, `:203-230`), which counts every problem of a touched module and only new ones of the rest; the line builds the counting in the indexer and names `indexer_validate_before`. Recommendation: change `causedProblems` in the assigner and name the tool `assigner_validate_before`. + answered: H-A-350 DMC-9. - **DMC-10** (§813 (7)) *A part named that is not.* No seat `artifact-store`: the sweep holds `mesh-artifact-sweep` (`artifact-store-tools`), the registry `mesh-artifact-store` and `oci-artifact-registry` (`distribution`); the registry's `list` takes `name`, not `module` (`seats/oci-artifact-registry/seat.json`). Recommendation: read "the seat `mesh-artifact-sweep`'s holder", and `list` takes `module` beside `name`. + answered: H-A-350 DMC-10. - **DMC-11** (§813 (5)) *A part assumed built that is not.* No tool `nats_consumers`: the bus module has `nats_consumer` (one) and `nats_backlog` (`mesh-catalog` `modules/nats/module.json`). Recommendation: `nats_consumers` is a new tool listing consumers with the two sorts. + answered: H-A-350 DMC-11. - **DMC-12** (§781, §813 (4)) *Parts assumed built that are not.* The node-engine seat has no `converged` and no verb with `timeout` ("built in H1" in the line; `mesh-contracts` `seats/node-engine/seat.json`); the packet filter's holder (`nftables`, TypeScript) serves `rules`, `reload`, `remove` and has no `allow`, asks no `converged` and holds no named 10 s (`mesh-catalog` `modules/nftables/client.ts`, `tools/index.ts`). Recommendation: the line says whether H2 builds `converged` with its `timeout` and `allow`, or the clauses about them leave H2. + answered: H-A-350 DMC-12. - **DMC-13** (§781) *A part assumed built that is not.* mesh-sdk has no settings reader: each module reads its `${config:}` files by names of its own (`mesh-delivery-pipeline/cmd/mesh-delivery-pipeline/askbounds.go:20-35`). Recommendation: a reader in mesh-sdk takes a setting by its key from the words the node-engine composes, in a process and in a bundle alike, and the runner's own readers move to it. + answered: H-A-350 DMC-13. - **DMC-14** (§812) *A part assumed built that is not.* A state write answers its revision only (`mesh-sdk` `go/state.go:177`, `:190`; `mesh-tools` `internal/bus/state.go:425`), and a publish's acknowledgement carries the stream and sequence, no fill. Recommendation: the runtime's write answer carries the entry's `Fill` (`buscalls.Fill` exists), which the prune helper judges. + answered: H-A-350 DMC-14. - **DMC-15** (§778) *A part assumed built that is not.* "Drops its ask through the seat's `drop`": `mesh-builds` (verbs `reserved`, `published`) and `mesh-wants` declare no `drop`; only the build-step part has one. Recommendation: D1 adds a `drop` act to both seats, its holder ending the ask as the build seats' `drop` does. + answered: H-A-350 DMC-15. - **DMC-16** (§791, §801) *A form the code cannot take as written.* The build-step part already has `output` (the whole answer in chunks by `ask` and `call`) and `current` (the steps, capacity, paused) in other forms (`mesh-delivery-contracts/parts/build-step.json`). Recommendation: the line's forms replace them with the part's `form` raised, the runner's tool their one reader. + answered: H-A-350 DMC-16.