diff --git a/04-ISSUES/300-a-new-module-is-not-built-at-its-merge/00-report.md b/04-ISSUES/300-a-new-module-is-not-built-at-its-merge/00-report.md index da3435f0..665f071e 100644 --- a/04-ISSUES/300-a-new-module-is-not-built-at-its-merge/00-report.md +++ b/04-ISSUES/300-a-new-module-is-not-built-at-its-merge/00-report.md @@ -25,7 +25,7 @@ another, with nothing on the mesh noting the difference. ## Why it is a design issue -ADR 0238 makes the change plan the planner's one answer for a pull request's check, the merge gate and +ADR 0238 makes the delivery plan the planner's one answer for a pull request's check, the merge gate and the merge. The plan counts a new module's directory as something the merge builds. The merge handler read the same answer (`touchedBy`'s `added`) and dropped it: it only walks modules the catalogue already holds, and a new one is not held until it is built. The code said so outright: "a new module, which a diff --git a/04-ISSUES/300-a-new-module-is-not-built-at-its-merge/01-diagnosis.md b/04-ISSUES/300-a-new-module-is-not-built-at-its-merge/01-diagnosis.md index 38491e27..65dab261 100644 --- a/04-ISSUES/300-a-new-module-is-not-built-at-its-merge/01-diagnosis.md +++ b/04-ISSUES/300-a-new-module-is-not-built-at-its-merge/01-diagnosis.md @@ -10,7 +10,7 @@ whatever stands on them. `touchedBy` is the one place the mesh maps a changed file onto a module (ADR 0238). It returns three answers: the touched modules, the `added` directories (a module that no module of the mesh is known -from) and the `unread` files. The change plan and the pull request's check take `added` as "new" and say +from) and the `unread` files. The delivery plan and the pull request's check take `added` as "new" and say it is built. The merge handler went through `whatTheMergeTouched`, which keeps only the first answer. Ruled out: