Issue 346: a setting a verb may set is pasted raw into its file, so an untrusted file is an injection point #246

Merged
mesh-admin merged 2 commits from issues/346-a-setting-a-verb-may-set-is-pasted-raw-into-its-file into main 2026-10-09 10:51:04 +00:00
Contributor

Registers issue 346 (status: located, severity high). Do not merge without review.

  • Symptom (review of mesh-catalog #157, 2026-10-09): with picom.conf marked "trusted": false, a settings call setting backend to xrender"; write-pid-path = "<path> adds an option of the caller's; picom then overwrites any file the operator can write (also log-file, shader paths, hiding rules, dummy). #157 was changed to keep the file trusted.
  • Cause (from the code, controller 4d60628): settingInto pastes plainly(value) raw; only line ends and NUL are refused (settingsHoldOneLine); settings have no type or allowed values; TerminalKeys opens a file's settings to the verb on "trusted": false alone.
  • Survey of main (7339ce8), every file marked trusted false: dunst dunstrc (INI, one key per line) not open; xdg user-dirs.dirs (shell-sourced format, "${setting:…}") open to command injection for any shell that sources it (none measured on the laptop, where the readers parse it). Recommended: mark user-dirs.dirs trusted again now.
  • Fix proposed (not built): typed settings (bool, int, enum, string with its file's format), validated at the verb and at composition, quoted at render per format; trusted: false only with every setting typed, checked by module check; until then nothing new goes trusted false.

merge-check.sh passes locally (records, index, cycle, words with the catalogue's list).

Registers issue 346 (status: located, severity high). Do not merge without review. - **Symptom (review of mesh-catalog #157, 2026-10-09):** with `picom.conf` marked `"trusted": false`, a `settings` call setting `backend` to `xrender"; write-pid-path = "<path>` adds an option of the caller's; picom then overwrites any file the operator can write (also `log-file`, shader paths, hiding rules, `dummy`). #157 was changed to keep the file trusted. - **Cause (from the code, controller `4d60628`):** `settingInto` pastes `plainly(value)` raw; only line ends and NUL are refused (`settingsHoldOneLine`); settings have no type or allowed values; `TerminalKeys` opens a file's settings to the verb on `"trusted": false` alone. - **Survey of main (`7339ce8`), every file marked trusted false:** `dunst` dunstrc (INI, one key per line) **not open**; `xdg` user-dirs.dirs (shell-sourced format, `"${setting:…}"`) **open** to command injection for any shell that sources it (none measured on the laptop, where the readers parse it). Recommended: mark user-dirs.dirs trusted again now. - **Fix proposed (not built):** typed settings (`bool`, `int`, `enum`, `string` with its file's format), validated at the verb and at composition, quoted at render per format; `trusted: false` only with every setting typed, checked by `module check`; until then nothing new goes trusted false. `merge-check.sh` passes locally (records, index, cycle, words with the catalogue's list).
mesh-admin added 1 commit 2026-10-09 10:35:53 +00:00
Issue 346: a setting a verb may set is pasted raw into its file, so an untrusted file is an injection point
mesh/merge-gate pass: the change touches no module of the mesh's graph
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery superseded: a newer head of the same pull request
79f31ca113
Found in the review of the picom settings: a backend of xrender"; write-pid-path = "… adds an option of
the caller's. The two files marked trusted false on main are judged (user-dirs.dirs open, dunstrc not),
and typed settings validated at the verb and quoted at render are proposed; until then nothing new goes
trusted false.
Author
Contributor

Delivery novox/hq@0ff6bd226726 — delivered since 2026-10-09T10:51:33Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

  • 2026-10-09 10:40 (new) → proposed (announced): novox/hq#246's head announced
  • 2026-10-09 10:42 proposed → checked (checked): the verdict names this commit
  • 2026-10-09 10:42 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-09 10:51 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-09 10:51 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/hq@0ff6bd226726` — **delivered** since 2026-10-09T10:51:33Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-09 10:40 (new) → proposed (announced): novox/hq#246's head announced - 2026-10-09 10:42 proposed → checked (checked): the verdict names this commit - 2026-10-09 10:42 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-09 10:51 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-09 10:51 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
jschoubben added 1 commit 2026-10-09 10:40:28 +00:00
Issue 346: user-dirs.dirs is trusted again for now (mesh-catalog #158), the stop-gap before the fix
mesh/merge-gate pass: the change touches no module of the mesh's graph
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery delivered
0ff6bd2267
mesh-admin merged commit 6a7cf421a9 into main 2026-10-09 10:51:04 +00:00
mesh-admin deleted branch issues/346-a-setting-a-verb-may-set-is-pasted-raw-into-its-file 2026-10-09 10:51:04 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/hq#246