ADR 0283: the username lives in its sources entry, and the needs-operator words as built (issue 386) #297

Merged
mesh-admin merged 2 commits from fix/386-username-in-sources into main 2026-10-10 20:25:24 +00:00
Contributor

Two dated progressive insights in ADR 0283 (issue 386), both from what the live mesh and the controller's own rules refused:

  • Decision 7: a separate setting smb-users was refused by the catalogue's module check (a key naming a user is the operator's value and may have no default, ADR 0262; one without a default would stop mounts composing until set). The username is the user part of the source's entry in sources. To-be 52 and the 0263 pointer note follow.
  • Decision 5: the controller's plain-words rule (ADR 0253) refuses the word agent in a condition's needs and explanation, so the words as built are "type at 's desk prompt." and "approve of on when it is proposed to you.".

What was decided stands. Code: mesh-controller#209, mesh-catalog#190.

Two dated progressive insights in ADR 0283 (issue 386), both from what the live mesh and the controller's own rules refused: - Decision 7: a separate setting `smb-users` was refused by the catalogue's module check (a key naming a user is the operator's value and may have no default, ADR 0262; one without a default would stop mounts composing until set). The username is the user part of the source's entry in `sources`. To-be 52 and the 0263 pointer note follow. - Decision 5: the controller's plain-words rule (ADR 0253) refuses the word agent in a condition's needs and explanation, so the words as built are "type <what> at <machine>'s desk prompt." and "approve <setting> of <module> on <machine> when it is proposed to you.". What was decided stands. Code: mesh-controller#209, mesh-catalog#190.
mesh-admin added 1 commit 2026-10-10 19:43:05 +00:00
Carry an SMB source's username in its sources entry, since a key naming a user may have no default (issue 386)
mesh/delivery superseded: a newer head of the same pull request
mesh/merge-gate pass: the change touches no module of the mesh's graph
mesh/repo-check pass: its merge-check.sh passed
a3ac9fd547
The live module check refused mesh-catalog#190's smb-users setting (ADR 0262);
ADR 0283 decision 7 gets a dated insight, to-be 52 and the 0263 note follow.
Author
Contributor

Delivery novox/hq@9a2a2006b1b8 — delivered since 2026-10-10T20:25:33Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

  • 2026-10-10 19:44 (new) → proposed (announced): novox/hq#297's head announced
  • 2026-10-10 19:45 proposed → checked (checked): the verdict names this commit
  • 2026-10-10 19:45 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-10 20:25 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-10 20:25 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/hq@9a2a2006b1b8` — **delivered** since 2026-10-10T20:25:33Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-10 19:44 (new) → proposed (announced): novox/hq#297's head announced - 2026-10-10 19:45 proposed → checked (checked): the verdict names this commit - 2026-10-10 19:45 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-10 20:25 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-10 20:25 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
mesh-admin left a comment
Author
Contributor

Independent review of a3ac9fd5. Verdict: REQUEST CHANGES. One finding blocks the merge, and it is a one-line fix. merge-check.sh passes (exit 0).

Both notes are correctly progressive insights, not a new record (0290). Each has the README form ('Progressive insight — 2026-10-10.'), is dated on the record's own date, adds rather than replaces, and quotes what stood before.

  • Decision 5: the needs words are reworded to meet ADR 0253's rules (the word 'agent' is refused, one sentence of at most 120 characters). The decision stands: the act is named, and 'nothing for you to do' is never said.
  • Decision 7: what was decided stands. The username is an ordinary setting that travels through a proposal, and the password is a one-line secret per source. Which setting key carries the username is a detail the decision did not rest on, and ADR 0262 is the reason it moved.

The 0263 note and to-be 52 are updated consistently. Refusing a password in the address is a good addition. The public-repo rule and the words are fine: placeholders only.

BLOCKING

  1. 0283 line 193, row 7 of 'How it is checked', still says 'a source without username waits for smb-users'. That setting no longer exists, so the row names a check that cannot be written. Either extend the decision-7 insight to cover the row, or add a dated insight on the table. The row should read: a source whose entry names no user waits for sources; a password in the address is refused (a test for the new refusal); without a password it waits for smb-password-<source>.

NON-BLOCKING
2. To-be 48 still says 'approve the setting when an agent proposes it' when it paraphrases the needs-operator words. That is not a quotation of the condition, but aligning it with the words as built ('when it is proposed to you') would keep the design and the record in step.

Independent review of a3ac9fd5. Verdict: REQUEST CHANGES. One finding blocks the merge, and it is a one-line fix. merge-check.sh passes (exit 0). Both notes are correctly progressive insights, not a new record (0290). Each has the README form ('Progressive insight — 2026-10-10.'), is dated on the record's own date, adds rather than replaces, and quotes what stood before. - Decision 5: the needs words are reworded to meet ADR 0253's rules (the word 'agent' is refused, one sentence of at most 120 characters). The decision stands: the act is named, and 'nothing for you to do' is never said. - Decision 7: what was decided stands. The username is an ordinary setting that travels through a proposal, and the password is a one-line secret per source. Which setting key carries the username is a detail the decision did not rest on, and ADR 0262 is the reason it moved. The 0263 note and to-be 52 are updated consistently. Refusing a password in the address is a good addition. The public-repo rule and the words are fine: placeholders only. BLOCKING 1. 0283 line 193, row 7 of 'How it is checked', still says 'a source without username waits for `smb-users`'. That setting no longer exists, so the row names a check that cannot be written. Either extend the decision-7 insight to cover the row, or add a dated insight on the table. The row should read: a source whose entry names no user waits for `sources`; a password in the address is refused (a test for the new refusal); without a password it waits for `smb-password-<source>`. NON-BLOCKING 2. To-be 48 still says 'approve the setting when an agent proposes it' when it paraphrases the needs-operator words. That is not a quotation of the condition, but aligning it with the words as built ('when it is proposed to you') would keep the design and the record in step.
jschoubben added 1 commit 2026-10-10 19:44:14 +00:00
Cover ADR 0283's check row 7 with the insight, and align to-be 48 with the words as built
mesh/merge-gate pass: the change touches no module of the mesh's graph
mesh/repo-check pass: its merge-check.sh passed
mesh/delivery delivered
9a2a2006b1
From the review of hq#297.
mesh-admin left a comment
Author
Contributor

Independent re-review of 9a2a2006. Verdict: APPROVE. It is posted as a comment because the forge takes only comments from this account. merge-check.sh passes (exit 0).

Both findings from the review of a3ac9fd5 are fixed:

  • Row 7 of 0283's check table now says that a source with no user waits for sources, that a password in the address is refused and never said, and that a source without a password waits for smb-password-<source>. The decision-7 insight quotes the row's old text, which is the README's rule for body text changed in place.
  • To-be 48 says 'when it is proposed to you', in step with the words as built.

Nothing else changed. The two progressive insights still leave decisions 5 and 7 standing, and the public-repo rule and the words are fine.

Independent re-review of 9a2a2006. Verdict: APPROVE. It is posted as a comment because the forge takes only comments from this account. merge-check.sh passes (exit 0). Both findings from the review of a3ac9fd5 are fixed: - Row 7 of 0283's check table now says that a source with no user waits for `sources`, that a password in the address is refused and never said, and that a source without a password waits for `smb-password-<source>`. The decision-7 insight quotes the row's old text, which is the README's rule for body text changed in place. - To-be 48 says 'when it is proposed to you', in step with the words as built. Nothing else changed. The two progressive insights still leave decisions 5 and 7 standing, and the public-repo rule and the words are fine.
mesh-admin merged commit eac30272ee into main 2026-10-10 20:25:24 +00:00
mesh-admin deleted branch fix/386-username-in-sources 2026-10-10 20:25:24 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/hq#297