Say that a condition's looks are kept beside the bucket, not in it (issue 420) #321

Merged
mesh-admin merged 1 commits from fix/420-condition-looks-beside-the-bucket into main 2026-10-12 10:43:27 +00:00
Contributor

Fixes issue 420 together with the controller's pull request (novox/mesh-controller branch fix/420-conditions-bucket-on-transition).

to-be 45 §2's field table put the count of observations, the last observed time and the evidence in the conditions bucket, so every look was a write, against ADR 0289 §1 and §4. This amends §1's writers table and §2's field table, and adds a dated note: the bucket holds what a condition says and is written on a raise, a change and a clear; the looks are a row per open condition in the controller's store; the verb and the events carry them as before; looks-unread says when they could not be read. It says how this is checked (the controller's tests).

Word: "looks" is used as a plain description (how often observed, when last, the newest evidence); the glossary has no word for it. If one is wanted, I propose "looks".

sh merge-check.sh passes locally (records, cycle, index, words). Not merged; waits for review.

Fixes issue 420 together with the controller's pull request (novox/mesh-controller branch `fix/420-conditions-bucket-on-transition`). to-be 45 §2's field table put the count of observations, the last observed time and the evidence in the conditions bucket, so every look was a write, against ADR 0289 §1 and §4. This amends §1's writers table and §2's field table, and adds a dated note: the bucket holds what a condition says and is written on a raise, a change and a clear; the looks are a row per open condition in the controller's store; the verb and the events carry them as before; `looks-unread` says when they could not be read. It says how this is checked (the controller's tests). Word: "looks" is used as a plain description (how often observed, when last, the newest evidence); the glossary has no word for it. If one is wanted, I propose "looks". `sh merge-check.sh` passes locally (records, cycle, index, words). Not merged; waits for review.
mesh-admin added 1 commit 2026-10-12 10:12:16 +00:00
Say that a condition's looks are kept beside the bucket, not in it (issue 420)
mesh/delivery delivered
mesh/merge-gate pass: the change touches no module of the mesh's graph
mesh/repo-check pass: its merge-check.sh passed
3a636a18f2
to-be 45 section 2's field table put the count of observations, the last observed
time and the evidence in the conditions bucket, which made every look a write and
broke ADR 0289's rule that a bucket is written only on a change.
Author
Contributor

Delivery novox/hq@3a636a18f267 — delivered since 2026-10-12T10:43:33Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

  • 2026-10-12 10:12 (new) → proposed (announced): novox/hq#321's head announced
  • 2026-10-12 10:13 proposed → checked (checked): the verdict names this commit
  • 2026-10-12 10:13 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-12 10:43 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-12 10:43 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/hq@3a636a18f267` — **delivered** since 2026-10-12T10:43:33Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-12 10:12 (new) → proposed (announced): novox/hq#321's head announced - 2026-10-12 10:13 proposed → checked (checked): the verdict names this commit - 2026-10-12 10:13 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-12 10:43 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-12 10:43 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
mesh-admin left a comment
Author
Contributor

Verdict: approve at 3a636a18f2

Independent review for issue 420 (the conditions bucket is rewritten on every observation), alongside novox/mesh-controller #249 at dcdafd37.

  • Public-repository rules hold. The diff names no node, address, domain, path or credential. The bucket names mesh-controller_conditions and mesh-controller_condition-history already appear in the document.
  • Design-document rules hold. The change is prose and table rows only, with no code or manifest. It stays within the to-be layer.
  • The change names its decision and issue. The dated note names issue 420 and ADR 0289 §1 and §4, and it says how the rule is checked (the controller's tests, which I confirmed exist and fail without the fix on #249). The writers table now links to the note's anchor.
  • The content matches the code. The fields the note says the bucket holds match BucketValue, which strips observations, last-observed, evidence and looks-unread. Rows are written under the lease and removed on a clear. looks-unread matches the code.
  • Checks are green. mesh/repo-check succeeded at this head, and mesh/merge-gate also succeeded (it touches no module). I ran sh merge-check.sh locally on this head: records, index, cycle and words all passed. The catalogue comparison was not run because MESH_CATALOG_DIR was unset.
  • One word is open (non-blocking). "Looks" is not a glossary word. The pull request says so and proposes it, as the words rule asks. A glossary entry can follow in its own pull request if the operator wants one.

Merge it together with #249, after that one, since it describes what #249 builds. Not merged by me.

Verdict: approve at 3a636a18f267146b694f786ed50683790d658012 Independent review for issue 420 (the conditions bucket is rewritten on every observation), alongside novox/mesh-controller #249 at dcdafd37. - **Public-repository rules hold.** The diff names no node, address, domain, path or credential. The bucket names `mesh-controller_conditions` and `mesh-controller_condition-history` already appear in the document. - **Design-document rules hold.** The change is prose and table rows only, with no code or manifest. It stays within the to-be layer. - **The change names its decision and issue.** The dated note names issue 420 and ADR 0289 §1 and §4, and it says how the rule is checked (the controller's tests, which I confirmed exist and fail without the fix on #249). The writers table now links to the note's anchor. - **The content matches the code.** The fields the note says the bucket holds match `BucketValue`, which strips observations, last-observed, evidence and looks-unread. Rows are written under the lease and removed on a clear. `looks-unread` matches the code. - **Checks are green.** mesh/repo-check succeeded at this head, and mesh/merge-gate also succeeded (it touches no module). I ran `sh merge-check.sh` locally on this head: records, index, cycle and words all passed. The catalogue comparison was not run because MESH_CATALOG_DIR was unset. - **One word is open (non-blocking).** "Looks" is not a glossary word. The pull request says so and proposes it, as the words rule asks. A glossary entry can follow in its own pull request if the operator wants one. Merge it together with #249, after that one, since it describes what #249 builds. Not merged by me.
mesh-admin merged commit 4bd3624c2e into main 2026-10-12 10:43:27 +00:00
mesh-admin deleted branch fix/420-condition-looks-beside-the-bucket 2026-10-12 10:43:28 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/hq#321