To-be 52: the home network's SMB and NFS shares become modules' (issue 613, ADR 0341) #341

Merged
mesh-admin merged 1 commits from design/613-home-network-shares into main 2026-10-13 09:08:52 +00:00
Contributor

What. Design 52 gains section 6, the home network: an smb-server module on the node seat node-smb-server, and nfs-server granting a share to local-network, both reached only from the home server's local network and the private network (ADR 0340's reach). It is the design home of ADR 0341. The glossary's share entry says a share may be granted to the local network and names an SMB share. "Not in this design" drops Samba and the home-network clients, which this section now covers.

Why. Issue 613: the operator said on 2026-10-13 that both shares are still used and are kept. ADR 0263 left Samba out ("Samba waits") and exported to nodes only.

Checked. merge-check.sh passes locally (records, index, cycle, words).

ADR 0341 needs the operator, and takes effect after ADR 0340. Issue 613.

**What.** Design 52 gains section 6, the home network: an `smb-server` module on the node seat `node-smb-server`, and `nfs-server` granting a share to `local-network`, both reached only from the home server's local network and the private network (ADR 0340's reach). It is the design home of ADR 0341. The glossary's *share* entry says a share may be granted to the local network and names an *SMB share*. "Not in this design" drops Samba and the home-network clients, which this section now covers. **Why.** Issue 613: the operator said on 2026-10-13 that both shares are still used and are kept. ADR 0263 left Samba out ("Samba waits") and exported to nodes only. **Checked.** `merge-check.sh` passes locally (records, index, cycle, words). ADR 0341 needs the operator, and takes effect after ADR 0340. Issue 613.
mesh-admin added 1 commit 2026-10-13 08:40:36 +00:00
Give ADR 0341 a home in design 52: the home network's SMB and NFS shares become modules' (issue 613)
mesh/merge-gate head c11cb994705b merged into trunk 6f09bda33cc1 — pass: the change touches no module of the mesh's graph
mesh/repo-check head c11cb994705b merged into trunk 6f09bda33cc1 — pass: its merge-check.sh passed
mesh/delivery delivered
c11cb99470
Author
Contributor

Delivery novox/hq@c11cb994705b — delivered since 2026-10-13T09:08:57Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

  • 2026-10-13 08:40 (new) → proposed (announced): novox/hq#341's head announced
  • 2026-10-13 08:41 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-13 08:41 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-13 09:08 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-13 09:08 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/hq@c11cb994705b` — **delivered** since 2026-10-13T09:08:57Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-13 08:40 (new) → proposed (announced): novox/hq#341's head announced - 2026-10-13 08:41 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-13 08:41 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-13 09:08 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-13 09:08 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
mesh-admin left a comment
Author
Contributor

Verdict: approve at c11cb99470

I read ADR 0341 and ADR 0263 through knowledge-base.get, cloned novox/hq over HTTPS under /var/tmp/review-hq341, checked out the pull request's head c11cb99470, read the diff against the merge base 6f09bda, and ran ./merge-check.sh.

  1. Design text against the record. Section 6's bullets restate ADR 0341's clauses faithfully: the seat and verbs of clause 2, the identity and refusal rule of clause 3, the protocol of clause 4, the password handling of clause 5, the configuration-file ownership and adopt behaviour of clauses 6 and 7, the local-network NFS grant and its refusal while port 2049 is not bound with that reach from clauses 8 and 9, the ZFS-adoption precondition of clause 10, the no-jail consequence of clause 12, and the no-data-moves consequence of clause 11. The section's opening paragraph and heading ("ADR 0341, after ADR 0340") correctly carry clause 14's gate: nothing is built into use before ADR 0340 is accepted and built, which matches ADR 0341's own status ("status": "proposed", "needs-operator": true, "waiting": "the operator's ask: waiting for the operator's answer") and the two "proposed: not in force" clauses I checked directly. The "Taking it into use" paragraph sequences already-decided acts (build, assign, dry run, a person's confirm, grant, adopt) and introduces no new rule. One gap: ADR 0341's clause 13 (smb-server's health, tool smb_health, answering waits before adoption) is not reflected anywhere in section 6 or in section 4's Conditions table, so the design is incomplete on that point, though nothing it does state contradicts the record. "Not in this design" is updated exactly as ADR 0341's Consequences describe (drops Samba and home-network clients, adds the announcement and NFS-version-3 exclusions).

  2. Glossary edit. The share entry gains the sentence on a local-network grant and a nested SMB share term, both citing ADR 0341. Nesting a second bold term inside an existing entry's bullet has precedent here (pair credential inside credential), so this keeps one entry per concept rather than opening a duplicate head word. words.py's own count ("155 head words, each once") confirms no entry is headed twice, and I found no existing Not: line or other glossary entry for "SMB share" or "Samba share" that this collides with or should have struck through.

  3. Public-repo rule. The diff uses only role names already established in this repository ("the home server", "the home network", "the private network") and generic Linux configuration paths already used elsewhere in to-be 52 (/etc/exports.d, /etc/systemd/system); I found no node name, hostname, literal address or operator-specific path in the diff.

  4. merge-check.sh, run from the pull request's head: "records: all checks passed"; "index: 6 topics in the reading order, no stored list"; "cycle: 436 documents checked, the chain holds"; "words: 28 retired words and 2 identifiers, none in running prose; 70 daemons' lines, none written; 155 head words, each once". Exit code 0.

I am approving despite the health/conditions gap in finding 1 because it is an omission rather than a wrong or invented statement, and every hard check (structure, cycle, words, the public-repo rule) passes. I recommend a follow-up to add smb-server's health to section 4's Conditions table before or shortly after the module ships.

Verdict: approve at c11cb994705b75c2222b3c27e8d842efa11d2504 I read ADR 0341 and ADR 0263 through knowledge-base.get, cloned novox/hq over HTTPS under /var/tmp/review-hq341, checked out the pull request's head c11cb994705b75c2222b3c27e8d842efa11d2504, read the diff against the merge base 6f09bda, and ran ./merge-check.sh. 1. Design text against the record. Section 6's bullets restate ADR 0341's clauses faithfully: the seat and verbs of clause 2, the identity and refusal rule of clause 3, the protocol of clause 4, the password handling of clause 5, the configuration-file ownership and adopt behaviour of clauses 6 and 7, the local-network NFS grant and its refusal while port 2049 is not bound with that reach from clauses 8 and 9, the ZFS-adoption precondition of clause 10, the no-jail consequence of clause 12, and the no-data-moves consequence of clause 11. The section's opening paragraph and heading ("ADR 0341, after ADR 0340") correctly carry clause 14's gate: nothing is built into use before ADR 0340 is accepted and built, which matches ADR 0341's own status ("status": "proposed", "needs-operator": true, "waiting": "the operator's ask: waiting for the operator's answer") and the two "proposed: not in force" clauses I checked directly. The "Taking it into use" paragraph sequences already-decided acts (build, assign, dry run, a person's confirm, grant, adopt) and introduces no new rule. One gap: ADR 0341's clause 13 (smb-server's health, tool smb_health, answering waits before adoption) is not reflected anywhere in section 6 or in section 4's Conditions table, so the design is incomplete on that point, though nothing it does state contradicts the record. "Not in this design" is updated exactly as ADR 0341's Consequences describe (drops Samba and home-network clients, adds the announcement and NFS-version-3 exclusions). 2. Glossary edit. The *share* entry gains the sentence on a local-network grant and a nested **SMB share** term, both citing ADR 0341. Nesting a second bold term inside an existing entry's bullet has precedent here (**pair credential** inside **credential**), so this keeps one entry per concept rather than opening a duplicate head word. words.py's own count ("155 head words, each once") confirms no entry is headed twice, and I found no existing *Not:* line or other glossary entry for "SMB share" or "Samba share" that this collides with or should have struck through. 3. Public-repo rule. The diff uses only role names already established in this repository ("the home server", "the home network", "the private network") and generic Linux configuration paths already used elsewhere in to-be 52 (/etc/exports.d, /etc/systemd/system); I found no node name, hostname, literal address or operator-specific path in the diff. 4. merge-check.sh, run from the pull request's head: "records: all checks passed"; "index: 6 topics in the reading order, no stored list"; "cycle: 436 documents checked, the chain holds"; "words: 28 retired words and 2 identifiers, none in running prose; 70 daemons' lines, none written; 155 head words, each once". Exit code 0. I am approving despite the health/conditions gap in finding 1 because it is an omission rather than a wrong or invented statement, and every hard check (structure, cycle, words, the public-repo rule) passes. I recommend a follow-up to add smb-server's health to section 4's Conditions table before or shortly after the module ships.
mesh-admin merged commit 58a6415ff5 into main 2026-10-13 09:08:52 +00:00
mesh-admin deleted branch design/613-home-network-shares 2026-10-13 09:08:53 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/hq#341