Playbook 07: review the local commits before anything is pushed #355

Merged
mesh-admin merged 1 commits from playbook-07-review-before-push into main 2026-10-14 21:12:21 +00:00
Contributor

The operator noticed (2026-10-14) that a push starts the forge's checks, which build the modules and run every test for up to a quarter of an hour, so pushing first and reviewing the pull request afterwards costs a full run for every finding. Step 4 becomes "finish, review, then publish": the independent review reads the local commits, and the branch is pushed only once it approves. A small change outside a feature goes the same way.

This change itself was reviewed that way: locally, two rounds (CHANGES, then APPROVE at local commit e1b37b8), before this push. MESH_CATALOG_DIR=../mesh-catalog sh merge-check.sh passes.

The operator noticed (2026-10-14) that a push starts the forge's checks, which build the modules and run every test for up to a quarter of an hour, so pushing first and reviewing the pull request afterwards costs a full run for every finding. Step 4 becomes "finish, review, then publish": the independent review reads the local commits, and the branch is pushed only once it approves. A small change outside a feature goes the same way. This change itself was reviewed that way: locally, two rounds (CHANGES, then APPROVE at local commit e1b37b8), before this push. `MESH_CATALOG_DIR=../mesh-catalog sh merge-check.sh` passes.
mesh-admin added 1 commit 2026-10-14 20:03:52 +00:00
Review the local commits before anything is pushed
mesh/merge-gate head 6c8532ce7090 merged into trunk c032cae10030 — pass: the change touches no module of the mesh's graph
mesh/repo-check head 6c8532ce7090 merged into trunk c032cae10030 — pass: its merge-check.sh passed
mesh/delivery delivered
6c8532ce70
A push starts the forge's checks, which build the modules and run every
test for up to a quarter of an hour, so a review finding fixed after the
push costs another full run (the operator, 2026-10-14).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
Contributor

Delivery novox/hq@6c8532ce7090 — delivered since 2026-10-14T21:12:32Z

Delivery plan — builds nothing: the change touches no module of the mesh's graph

Transitions

  • 2026-10-14 20:04 (new) → proposed (announced): novox/hq#355's head announced
  • 2026-10-14 20:05 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit
  • 2026-10-14 20:05 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-14 21:12 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-14 21:12 published → delivered (done): nothing for a walk to move

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/hq@6c8532ce7090` — **delivered** since 2026-10-14T21:12:32Z **Delivery plan** — builds nothing: the change touches no module of the mesh's graph **Transitions** - 2026-10-14 20:04 (new) → proposed (announced): novox/hq#355's head announced - 2026-10-14 20:05 proposed → checked (checked): a verdict names this commit and the trunk's head as its trunk commit - 2026-10-14 20:05 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-14 21:12 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-14 21:12 published → delivered (done): nothing for a walk to move The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
mesh-admin merged commit 35d5b2814f into main 2026-10-14 21:12:21 +00:00
mesh-admin deleted branch playbook-07-review-before-push 2026-10-14 21:12:22 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/hq#355