Design 42: the zfs module owns a node's ZFS and changes nothing that is not set (ADR 0679, issue 1979) #596

2026-11-12T22:21:34Z

mesh-tools commented

2026-11-12 22:21:34 +00:00

Adds the zfs module to design 42 as row 12 with a section of its own, and the milestone part 42-milestones/zfs-owns-zfs.md (lines §1-§31), from ADR 0679 (accepted 2026-11-12). Issue 1979 is the milestone's issue; its three node-engine subtasks are §1-§3 (an apply stops at its first failed resource, if-config, the list-to-lines template form), read in order by mesh-sdk, the manifest validator and the node-engine (§4-§6). Adds the glossary entry ZFS snapshot.

Review by architectural domain: one round (security and upgrade, seams and tools, running and testing, health and events, 2026-11-12 ~23:15 CET) on head f26c8afc; its findings, consolidated with the lead's answers (20 items), are all fixed in 224348ff. Three were fixed differently, as the lead accepted: the module's stream tool is zfs_module_events (zfs_events exists); "the manifest validator" (glossary word); /etc/hostid is written by the apply with zgenhostid -f, only when the pool's label shows host id 0 or the same value, since a template cannot write the binary file (noted on issue 1979 against ADR 0679 §9). go test ./... passes.

Reviewed-by: review by architectural domain (four reviewers) at f26c8afc, findings answered at 224348ff4d
Pushed-by: fix-1977@ace

Adds the zfs module to design 42 as row 12 with a section of its own, and the milestone part `42-milestones/zfs-owns-zfs.md` (lines §1-§31), from ADR 0679 (accepted 2026-11-12). Issue 1979 is the milestone's issue; its three node-engine subtasks are §1-§3 (an apply stops at its first failed resource, `if-config`, the list-to-lines template form), read in order by mesh-sdk, the manifest validator and the node-engine (§4-§6). Adds the glossary entry ZFS snapshot. Review by architectural domain: one round (security and upgrade, seams and tools, running and testing, health and events, 2026-11-12 ~23:15 CET) on head f26c8afc; its findings, consolidated with the lead's answers (20 items), are all fixed in 224348ff. Three were fixed differently, as the lead accepted: the module's stream tool is `zfs_module_events` (`zfs_events` exists); "the manifest validator" (glossary word); /etc/hostid is written by the apply with `zgenhostid -f`, only when the pool's label shows host id 0 or the same value, since a template cannot write the binary file (noted on issue 1979 against ADR 0679 §9). `go test ./...` passes. Reviewed-by: review by architectural domain (four reviewers) at f26c8afc, findings answered at 224348ff4d69cb58a76b62270f0752bf0032e56a Pushed-by: fix-1977@ace

mesh-tools added 4 commits 2026-11-12 22:21:34 +00:00

Design 42: the zfs module owns a machine's ZFS and changes nothing unset (ADR 0679) 6772904668

Adds row 12 and a section to the main file, and the milestone part
zfs-owns-zfs with numbered lines and its three prerequisites, so a
builder takes ownership of ZFS's packages, files, units and one pool's
devices, properties and scheduled ZFS snapshots without a choice of
its own. Leaves one design question open (a resource that follows a
value only once it is set). Adds ZFS snapshot to the glossary beside
the two snapshots it already names.

Design 42 zfs-owns-zfs: answer the open question in the node-engine, name issue 1979 0ea81e0e96

The lead answered that a resource following a set value and one line
per list entry are built in the node-engine in this milestone, so the
module's files, units and handlers are placed only once their value is
set, as ADR 0679 holds. The cron-to-calendar fix leaves the milestone
and stays an ordering edge the scheduled run waits on.

Design 42 zfs-owns-zfs: schedule the run in list form, so nothing waits on the calendar fix f26c8afc20

Today's node-engine writes a cron step as an invalid calendar but a
minute list as a valid one, so the scheduled run declares
0,15,30,45 and the milestone no longer waits on another session's fix.

Design 42 zfs-owns-zfs: answer review round 1 against ADR 0679 version 11

mesh/delivery merged: source.main moved to novox/hq@b9cd0bc492ac

Details

mesh/check being carried to 224348ff4d69 on b9cd0bc492ac | from 9ebf6e58f0d7

224348ff4d

Cites the record's final clauses, drops the catalog check and every
write of the package's files, and writes the lead's answers as design
lines: a run that never waits on a scrub, waits ended by events,
ZFS snapshots kept in the ledger before any removal, hand acts as unit
instances, subjects per kind, the follower's findings, the readers of
the new manifest words and one node-engine integration test.

mesh-tools commented

2026-11-12 22:21:37 +00:00

Delivery novox/hq@224348ff4d69 — merged since 2026-11-12T22:34:22Z

Source — source.main moved to novox/hq@b9cd0bc492. Whether it reached the machines is mesh-delivery-view's, derived from source.main, the wants and the haves.

Transitions

2026-11-12 22:21 (new) → proposed (announced): novox/hq#596's head announced
2026-11-12 22:21 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false)
2026-11-12 22:34 ready → merged (merged): on the trunk its modules follow: merged there

The commit's note under refs/notes/mesh-plan keeps every transition of this change up to its merge: git log --notes=mesh-plan.

**Delivery** `novox/hq@224348ff4d69` — **merged** since 2026-11-12T22:34:22Z **Source** — source.main moved to novox/hq@b9cd0bc492ac. Whether it reached the machines is `mesh-delivery-view`'s, derived from `source.main`, the wants and the haves. **Transitions** - 2026-11-12 22:21 (new) → proposed (announced): novox/hq#596's head announced - 2026-11-12 22:21 proposed → ready (accepted): a verdict names this commit and the trunk's head as its trunk commit, the gate passed or warned, and the repository's own check did not fail; or the check gates no merge (check-gates-merge false) - 2026-11-12 22:34 ready → merged (merged): on the trunk its modules follow: merged there The commit's note under `refs/notes/mesh-plan` keeps every transition of this change up to its merge: `git log --notes=mesh-plan`.

mesh-tools merged commit b9cd0bc492 into main

2026-11-12 22:34:20 +00:00

mesh-tools deleted branch design/42-zfs-owns-zfs

2026-11-12 22:34:20 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novox/hq#596