From 0e7eb9c2dac8d0d3b9cd661f96f043922fb5cc25 Mon Sep 17 00:00:00 2001 From: jochen Date: Sat, 17 Oct 2026 17:29:43 +0200 Subject: [PATCH 1/2] Playbook 07: read a failed check's whole log; a change to merge-check.sh is judged by main's version --- 00-META/process/07-feature-branches.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/00-META/process/07-feature-branches.md b/00-META/process/07-feature-branches.md index b4f5d008..363aa062 100644 --- a/00-META/process/07-feature-branches.md +++ b/00-META/process/07-feature-branches.md @@ -143,7 +143,12 @@ never into the running one, unless it blocks the running one. 2. **The forge's merge checks run the integration tests once** (`mesh/merge-gate`, `mesh/repo-check`). No second review: phase 2 reviewed this tree. 3. **A check that fails** goes back to the reviewer with the failure, for **one more cycle** of phase 2 with - the same fixing agents; then push once again. + the same fixing agents; then push once again. **The failure is read from the check's whole log**, never + reasoned from its summary: `mesh-delivery.show` names the check's build id, and `mesh-controller.builds` with + `log` set to that id prints everything the build machine said. A check's summary picks only some failing lines; + on 2026-10-17 it showed a store test's `FAIL` without its cause, and a fix was first guessed from the code. + **A change to `merge-check.sh` is judged by main's version of it**, so a test the change adds must pass under + either version: one that runs the new script's behaviour runs a file of its own, never `merge-check.sh` itself. 4. **The milestone's acceptance is proven before it is marked ready.** A milestone that adds or changes a module carries an integration test that starts the module whole, its process against the real bus and store, and shows the milestone's acceptance sentence; the forge's checks run it (ADR 0391 §1, §6). Unit tests alone are not -- 2.54.0 From 06440c15229821fa53335166ed899bdc11989306 Mon Sep 17 00:00:00 2001 From: jochen Date: Sat, 17 Oct 2026 17:56:21 +0200 Subject: [PATCH 2/2] Playbook 07: the build seat's holder, not a retired word (review of #405's check) --- 00-META/process/07-feature-branches.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/00-META/process/07-feature-branches.md b/00-META/process/07-feature-branches.md index 363aa062..ff49b4ac 100644 --- a/00-META/process/07-feature-branches.md +++ b/00-META/process/07-feature-branches.md @@ -145,7 +145,7 @@ never into the running one, unless it blocks the running one. 3. **A check that fails** goes back to the reviewer with the failure, for **one more cycle** of phase 2 with the same fixing agents; then push once again. **The failure is read from the check's whole log**, never reasoned from its summary: `mesh-delivery.show` names the check's build id, and `mesh-controller.builds` with - `log` set to that id prints everything the build machine said. A check's summary picks only some failing lines; + `log` set to that id prints everything the build seat's holder said. A check's summary picks only some failing lines; on 2026-10-17 it showed a store test's `FAIL` without its cause, and a fix was first guessed from the code. **A change to `merge-check.sh` is judged by main's version of it**, so a test the change adds must pass under either version: one that runs the new script's behaviour runs a file of its own, never `merge-check.sh` itself. -- 2.54.0