From 0a446c757211ced84afb8fe4f279dadb0e5259f1 Mon Sep 17 00:00:00 2001 From: jochen Date: Thu, 19 Nov 2026 15:38:16 +0100 Subject: [PATCH] build modules: cite A-489b on the step-ends kit case, its check and the node's need MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Builds: design 47 G §24; lead answer A-489b Claude-Session: https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy --- checks/failurekit/failurekit.go | 2 +- modules/mesh-build-go/cmd/mesh-build-go/kit_test.go | 2 +- modules/mesh-build-image/cmd/mesh-build-image/kit_test.go | 2 +- modules/mesh-build-node/cmd/mesh-build-node/kit_test.go | 2 +- modules/mesh-build-node/cmd/mesh-build-node/lint.go | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/checks/failurekit/failurekit.go b/checks/failurekit/failurekit.go index aa422e9a8..934992930 100644 --- a/checks/failurekit/failurekit.go +++ b/checks/failurekit/failurekit.go @@ -91,7 +91,7 @@ func Judge(root string) ([]Judged, error) { refused = append(refused, fmt.Sprintf("it claims %s, and no test of it calls conformance.LeftRunning "+ "(mesh-build-go buildstep/conformance): run the kit's left-running case with the module's own start sweep (issue 1890)", seat)) } - // Every build module is asked pipeline steps, so every one runs the case that its steps can say a step's end: without a + // A-489b: every build module is asked pipeline steps, so every one runs the case that its steps can say a step's end: without a // SayStep every step ask is refused live ("this build module says no step's end"), as mesh-build-node's was. ends, err := runsTheKit(dir, "conformance.StepEnds(") if err != nil { diff --git a/modules/mesh-build-go/cmd/mesh-build-go/kit_test.go b/modules/mesh-build-go/cmd/mesh-build-go/kit_test.go index 7fef9f003..c311d63cb 100644 --- a/modules/mesh-build-go/cmd/mesh-build-go/kit_test.go +++ b/modules/mesh-build-go/cmd/mesh-build-go/kit_test.go @@ -57,7 +57,7 @@ func TestTheStepsSayAFailedNetworkAsATransportFault(t *testing.T) { }) } -// Design 47 G §24 (*Asked on a work queue, ended by an event*): the module's own steps can say a pipeline step's end, or +// A-489b, design 47 G §24: the module's own steps can say a pipeline step's end, or // every step ask the runner sends it is refused ("this build module says no step's end"), as the first live pipeline met. func TestTheStepsCanSayAStepsEnd(t *testing.T) { conformance.StepEnds(t, (&Module{Node: "kitnode"}).askSteps(nil)) diff --git a/modules/mesh-build-image/cmd/mesh-build-image/kit_test.go b/modules/mesh-build-image/cmd/mesh-build-image/kit_test.go index 4be8b9158..4aaead31f 100644 --- a/modules/mesh-build-image/cmd/mesh-build-image/kit_test.go +++ b/modules/mesh-build-image/cmd/mesh-build-image/kit_test.go @@ -45,7 +45,7 @@ func TestTheStepsSayAFailedNetworkAsATransportFault(t *testing.T) { }) } -// Design 47 G §24 (*Asked on a work queue, ended by an event*): the module's own steps can say a pipeline step's end, or +// A-489b, design 47 G §24: the module's own steps can say a pipeline step's end, or // every step ask the runner sends it is refused ("this build module says no step's end"), as the first live pipeline met. func TestTheStepsCanSayAStepsEnd(t *testing.T) { conformance.StepEnds(t, (&Module{Node: "kitnode"}).askSteps(nil)) diff --git a/modules/mesh-build-node/cmd/mesh-build-node/kit_test.go b/modules/mesh-build-node/cmd/mesh-build-node/kit_test.go index dfbb88ded..157c614c2 100644 --- a/modules/mesh-build-node/cmd/mesh-build-node/kit_test.go +++ b/modules/mesh-build-node/cmd/mesh-build-node/kit_test.go @@ -50,7 +50,7 @@ func TestTheStepsSayAFailedNetworkAsATransportFault(t *testing.T) { }) } -// Design 47 G §24 (*Asked on a work queue, ended by an event*): the module's own steps can say a pipeline step's end, or +// A-489b, design 47 G §24: the module's own steps can say a pipeline step's end, or // every step ask the runner sends it is refused ("this build module says no step's end"), as the first live pipeline met. func TestTheStepsCanSayAStepsEnd(t *testing.T) { conformance.StepEnds(t, (&Module{Node: "kitnode"}).askSteps(nil)) diff --git a/modules/mesh-build-node/cmd/mesh-build-node/lint.go b/modules/mesh-build-node/cmd/mesh-build-node/lint.go index 832a32941..2afeb2fb1 100644 --- a/modules/mesh-build-node/cmd/mesh-build-node/lint.go +++ b/modules/mesh-build-node/cmd/mesh-build-node/lint.go @@ -51,6 +51,6 @@ func (m *Module) lintStep(ctx context.Context, args map[string]any) (any, error) return steprun.LintAnswer{Failed: failed, Nothing: !linted}, nil } -// Has says whether this node has a need a package's tests name (sdkstep.AskNeeds): the need node-build-node is this module's own +// A-489b: Has says whether this node has a need a package's tests name (sdkstep.AskNeeds): the need node-build-node is this module's own // (a TypeScript package's tests run through it); any other it lacks. func (m *Module) Has(need string) bool { return need == sdkstep.NeedNodeBuildNode }