From 1171b684d08beb7eb385f4f76798262932c76c85 Mon Sep 17 00:00:00 2001 From: jochen Date: Sun, 8 Nov 2026 01:00:40 +0100 Subject: [PATCH] Round 1: distribution's manifest test expects the artifact-store alias the bootstrap keeps The review of 6547933b: the test still wanted the provision retired, though 80b8002a and 0c465fb9 keep it on port 5100 for the running node-engines; it failed on main too (issue 1966). Claude-Session: https://claude.ai/code/session_01NcbgfFfQ4Z9UE5jK32PmE5 --- modules/distribution/internal/holder/holder_test.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/modules/distribution/internal/holder/holder_test.go b/modules/distribution/internal/holder/holder_test.go index 040aa9d21..473c11379 100644 --- a/modules/distribution/internal/holder/holder_test.go +++ b/modules/distribution/internal/holder/holder_test.go @@ -843,10 +843,12 @@ func TestTheHolderOfTheTwoImageSeats(t *testing.T) { if m.Packages["git.novox.be/novox/mesh-delivery/modules/mesh-delivery-builder/builds"] != "0.1" { t.Errorf("packages %v: want builds of series 0.1", m.Packages) } - // E15: the provision artifact-store retired (ADR 0632 §3): distribution provides and serves nothing, and the - // store is found by its seats' holder and the listen it opens to the mesh. - if len(m.Provides) != 0 || len(m.Serves) != 0 { - t.Errorf("provides = %+v, serves = %v, want neither: the provision artifact-store retired", m.Provides, m.Serves) + // E15: the provision artifact-store retires (ADR 0632 §3); the bootstrap keeps it as an alias on port 5100 while + // the running node-engines still find the store by it (issue 1966), and nothing else is provided or served. + alias, _ := m.Serves["artifact-store"].(map[string]any) + port, _ := alias["port"].(float64) + if len(m.Provides) != 1 || m.Provides[0].Name != "artifact-store" || len(m.Serves) != 1 || port != 5100 { + t.Errorf("provides = %+v, serves = %v, want only the artifact-store alias on port 5100", m.Provides, m.Serves) } claims := map[string][]string{} for _, c := range m.Claims {