Make the catalogue test strict: the gate alone claims the seat, and say the old module is gone (ADR 0454, issue 1351)

modules/mesh-issues/cmd/mesh-issues/check.go

@@ -222,7 +222,7 @@ var LinkKinds = []string{LinkDuplicates, LinkRelatesTo, LinkDependsOn, LinkPullR
 var (
 	pullRequest = regexp.MustCompile(`^[a-z0-9][a-z0-9._-]{0,99}#[1-9][0-9]{0,6}$`)
 	decision    = regexp.MustCompile(`^[0-9]{4}$`)
-	// deliveryID mirrors mesh-delivery's `IDOf` (modules/mesh-delivery/cmd/mesh-delivery/model.go): the forge's
+	// deliveryID mirrors the delivery gate's `IDOf` (modules/mesh-delivery-gate/cmd/mesh-delivery-gate/model.go): the forge's
 	// repository as owner/name, lower-cased, `@` and at most twelve characters of its commit. The pattern this
 	// replaced took neither the slash nor the `@`, so no delivery could be linked (novox/hq issue 475).
 	deliveryID  = regexp.MustCompile(`^[a-z0-9][a-z0-9._-]{0,99}/[a-z0-9][a-z0-9._-]{0,99}@[0-9a-f]{1,12}$`)

modules/mesh-issues/cmd/mesh-issues/manifest_test.go

@@ -5,6 +5,7 @@ import (
 	"os"
 	"path/filepath"
 	"reflect"
+	"slices"
 	"sort"
 	"strings"
 	"testing"
@@ -171,7 +172,13 @@ func TestTheSettingsStartTheCounterAndRegisterTheOwners(t *testing.T) {
 		}
 	}
 	modules := filepath.Join("..", "..", "..")
+	// retired are modules the catalogue no longer holds that stay registered, because issues are located in them
+	// (novox/hq ADR 0454, issue 1351: today's delivery module, removed after the gate took the seat).
+	retired := []string{"mesh-catalog modules/mesh-delivery"}
 	for _, o := range s.Owners {
+		if slices.Contains(retired, o) {
+			continue
+		}
 		if name, ok := strings.CutPrefix(o, "mesh-catalog modules/"); ok {
 			if _, err := os.Stat(filepath.Join(modules, name, "module.json")); err != nil {
 				t.Errorf("the owner %q names a module the catalogue does not hold", o)