mesh-issues: read merged from the pull request, not the state, so a closed one is withdrawn (hq issue 483)

mesh-delivery says stopped for a pull request closed unmerged too; read as
merged, it was said stuck to the operator for good. Cite ADR 0284 for the
worker rules, which the comments gave as 0283.

modules/mesh-issues/cmd/mesh-issues/tracker.go

@@ -330,9 +330,9 @@ type MoveAsk struct {
 	Replay        string
 	ReplayNone    string
 	Reason        string
-	// By is who works on it, who@node: what a move to diagnosing or fixing needs (ADR 0283 §1).
+	// By is who works on it, who@node: what a move to diagnosing or fixing needs (ADR 0284 §2).
 	By string
-	// TakeOver is why the issue is taken over from another worker (ADR 0283 §1).
+	// TakeOver is why the issue is taken over from another worker (ADR 0284 §3).
 	TakeOver string
 }
 
@@ -422,7 +422,7 @@ func (t *Tracker) move(by string, a MoveAsk) (*Moved, error) {
 	if reason != "" && to != StatusWontfix {
 		return nil, fmt.Errorf("reason is what wontfix needs; this moves to %s", to)
 	}
-	// Who works on it (ADR 0283 §1): named on a move to diagnosing or fixing, and on no other.
+	// Who works on it (ADR 0284 §2): named on a move to diagnosing or fixing, and on no other.
 	var worker, takeOver string
 	if worked(to) {
 		if strings.TrimSpace(a.By) == "" {
@@ -507,7 +507,7 @@ func (t *Tracker) move(by string, a MoveAsk) (*Moved, error) {
 	out := &Moved{Number: is.Number, From: from, To: to, Changed: changed, By: by, TookOverFrom: work.from, Released: work.released,
 		Said: fmt.Sprintf("Issue %d moved from %s to %s.", is.Number, from, to)}
 	// The event's by is who works on it when the move names them, and who acted otherwise; caller is always who
-	// acted, as the runtime proves it (ADR 0283 §4).
+	// acted, as the runtime proves it (ADR 0284 §6).
 	body := map[string]any{"number": is.Number, "from": from, "to": to, "by": by, "caller": by, "at": t.now()}
 	if is.Worker != nil {
 		since := is.Worker.Since
@@ -553,7 +553,7 @@ func (t *Tracker) move(by string, a MoveAsk) (*Moved, error) {
 }
 
 // cycleRules is what the development cycle asks of an issue moving from one status to another (playbook 03,
-// to-be 53 §5, ADR 0283), said as the rule that refused it.
+// to-be 53 §5, ADR 0284), said as the rule that refused it.
 func cycleRules(is *Issue, from, to string) error {
 	switch to {
 	case StatusLocated:
@@ -562,7 +562,7 @@ func cycleRules(is *Issue, from, to string) error {
 				"(a repository, or \"mesh-catalog modules/<module>\")", is.Number)
 		}
 	case StatusResolved:
-		// Resolved only from fixing: whoever fixed it said so when they started (ADR 0283 §3). A resolved issue
+		// Resolved only from fixing: whoever fixed it said so when they started (ADR 0284 §5). A resolved issue
 		// may still have what it holds corrected.
 		if from != StatusFixing && from != StatusResolved {
 			return fmt.Errorf("issue %d is %s, and an issue is resolved only from fixing: move it to fixing with by, "+
@@ -740,7 +740,7 @@ type Row struct {
 	// Delivery is whether its fix is delivered, in words (ADR 0281); empty when fixed-by names no pull request.
 	Delivery string `json:"delivery,omitempty"`
 	// Worker is who works on it and Since since when, while it is diagnosing or fixing; Stale says nobody did
-	// anything on it for worker-stale-after, so it may be taken over without a reason (ADR 0283).
+	// anything on it for worker-stale-after, so it may be taken over without a reason (ADR 0284 §4).
 	Worker string     `json:"worker,omitempty"`
 	Since  *time.Time `json:"since,omitempty"`
 	Stale  bool       `json:"stale,omitempty"`