Take the bus's backup guard out of modules/nats: it would move the bus (issue 1098, guard follows in issue 1104)

2026-10-18 03:55:50 +02:00
parent 68e3326d4c
commit 3bc4215d87
1 changed files with 0 additions and 72 deletions
@@ -1,72 +0,0 @@
 package main
 import (
 	"encoding/json"
 	"os"
 	"strings"
 	"testing"
 )
 // The bus's storage stays declared as data protected by a backup (novox/hq ADR 0408 clause 7; issue 1098): the
 // assignments, rollouts and builds now live in the bus's buckets, so a manifest that stopped saying so would leave
 // the one copy of them unprotected. The storage directory is declared as valuable data with a dump into the
 // snapshots directory, which is itself declared.
 func TestTheBusStorageIsDeclaredAsDataProtectedByABackup(t *testing.T) {
 	raw, err := os.ReadFile("../../module.json")
 	if err != nil {
 		t.Fatal(err)
 	}
 	var m struct {
 		Data struct {
 			Own []struct {
 				ID     string `json:"id"`
 				Path   string `json:"path"`
 				Class  string `json:"class"`
 				Backup *struct {
 					Dump string `json:"dump"`
 					Into string `json:"into"`
 				} `json:"backup"`
 			} `json:"own"`
 		} `json:"data"`
 		Resources []struct {
 			ID   string `json:"id"`
 			Type string `json:"type"`
 		} `json:"resources"`
 	}
 	if err := json.Unmarshal(raw, &m); err != nil {
 		t.Fatal(err)
 	}
 	var storage, snapshots bool
 	for _, d := range m.Data.Own {
 		switch d.ID {
 		case "jetstream":
 			if d.Path != "${dir:jetstream-data}" || d.Class != "valuable" {
 				t.Errorf("the bus's storage is declared as %q, class %q", d.Path, d.Class)
 			}
 			if d.Backup == nil || strings.TrimSpace(d.Backup.Dump) == "" || d.Backup.Into != "snapshots" {
 				t.Errorf("the bus's storage has no dump into the snapshots: %+v", d.Backup)
 			}
 			storage = true
 		case "snapshots":
 			snapshots = true
 		}
 	}
 	if !storage || !snapshots {
 		t.Errorf("the bus's storage declared: %v, and its snapshots: %v", storage, snapshots)
 	}
 	var dirs []string
 	for _, r := range m.Resources {
 		if r.Type == "directory" {
 			dirs = append(dirs, r.ID)
 		}
 	}
 	for _, want := range []string{"jetstream-data", "snapshots"} {
 		found := false
 		for _, id := range dirs {
 			found = found || id == want
 		}
 		if !found {
 			t.Errorf("the directory %s is not a declared resource (directories: %v)", want, dirs)
 		}
 	}
 }