Hold every build module to ending what a previous process left running (issue 1890)

A replaced mesh-build-go left a check ask's step running and its start
sweep spared it (issue 1890, note 21). mesh-build-go, mesh-build-node and
mesh-build-image pin mesh-sdk 981a35b5, whose steps name their owner and
whose sweep ends another owner's at once; each runs the sweep through one
method that main calls and that its test runs through the conformance
kit's left-running case. The failurekit check now refuses a build module
whose tests do not run that case, test step or not.

modules/mesh-build-node/cmd/mesh-build-node/asks.go

@@ -2,6 +2,7 @@ package main
 
 import (
 	"context"
+	"time"
 
 	stdio "git.novox.be/novox/mesh-sdk/go"
 	"git.novox.be/novox/mesh-sdk/go/buildstep"
@@ -86,6 +87,13 @@ func (m *Module) SeatTools(p *buildstep.Puller) []stdio.Tool {
 // StepEndTool ends one step left running (issue 1890); the module's steps state is the one it reads and writes.
 const StepEndTool = "build_node_step_end"
 
+// endLeftRunning is the module's start sweep (issue 1890): it ends the steps of its node that a previous process left
+// running (buildstep.EndStaleAtStart; every step names its owner). main runs it once at the start, and the module's test
+// runs it through the conformance kit's left-running case.
+func (m *Module) endLeftRunning(ctx context.Context, scan buildstep.Scan, booted time.Time, logf func(string, ...any)) {
+	buildstep.EndStaleAtStart(ctx, scan, m.Node, booted, logf)
+}
+
 // stepScan is the module's steps state as buildstep reads it.
 func (m *Module) stepScan() buildstep.Scan {
 	return buildstep.ScanOf(stdio.State(delivery.StepsState))

modules/mesh-build-node/cmd/mesh-build-node/kit_test.go

@@ -1,7 +1,9 @@
 package main
 
 import (
+	"context"
 	"testing"
+	"time"
 
 	"git.novox.be/novox/mesh-sdk/go/buildstep"
 	"git.novox.be/novox/mesh-sdk/go/buildstep/conformance"
@@ -18,3 +20,12 @@ func TestTheTestStepKeepsTheFailureContract(t *testing.T) {
 		return testFailures(".", "type-check", o.Dir, forgekey.Ran{Status: 2, Stdout: o.Stdout, Stderr: o.Stderr}, "")
 	})
 }
+
+// 1890/AC7: the module's own start sweep (endLeftRunning, as main runs it) keeps the conformance kit's left-running
+// case: a step a previous process left running is ended at once and said, whatever its age, and a step of this process
+// is kept.
+func TestTheStartSweepEndsWhatAPreviousProcessLeft(t *testing.T) {
+	conformance.LeftRunning(t, func(ctx context.Context, scan buildstep.Scan, node string, before time.Time, logf func(string, ...any)) {
+		(&Module{Node: node}).endLeftRunning(ctx, scan, before, logf)
+	})
+}

modules/mesh-build-node/cmd/mesh-build-node/main.go

@@ -9,7 +9,6 @@ package main
 import (
 	"context"
 	"fmt"
-	"git.novox.be/novox/mesh-sdk/go/buildstep"
 	"os"
 	"os/user"
 	"path/filepath"
@@ -75,8 +74,9 @@ func main() {
 	puller := m.Puller(steps, nil)
 	m.Held = puller
 	if m.Node != "" {
-		// A step a previous process left running is ended (issue 1890); this process's own steps start after booted.
-		go buildstep.EndStaleAtStart(ctx, m.stepScan(), m.Node, booted, logf)
+		// A step a previous process left running is ended (issue 1890): one that names another owner, or none and
+		// started before booted.
+		go m.endLeftRunning(ctx, m.stepScan(), booted, logf)
 	}
 	if m.Node != "" {
 		// The seat's asks, pulled once Serve has the runtime's channel; a pull before it is said and tried again.