CAT-P1: the overview page's model: three blocks from the ledger and three sources' verbs and events
The model is built once at start from the issue tracker's milestones and list, the delivery groups and the operator channel's asks, and kept in memory from their events (group, transition, merged; offered, closed; opened, moved, milestone-set, milestone-moved), asking no verb again; the records come from the ledger and the seven days are counted when the answer is given. The manifest invokes groups and asks, consumes those events, has no reads and no decided family. Issue 1968. Claude-Session: https://claude.ai/code/session_01JG73KJNrH5EgFXMKKYSrig
This commit is contained in:
@@ -0,0 +1,101 @@
|
||||
package main
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
// overviewWorld is a page model over the sources played here: what each verb answers, and what fails.
|
||||
type overviewWorld struct {
|
||||
o *Overview
|
||||
now time.Time
|
||||
answers map[string]string
|
||||
fail map[string]bool
|
||||
entries []*Entry
|
||||
}
|
||||
|
||||
func newOverviewWorld(t *testing.T) *overviewWorld {
|
||||
t.Helper()
|
||||
w := &overviewWorld{now: time.Date(2026, 11, 4, 12, 0, 0, 0, time.UTC), fail: map[string]bool{}, answers: map[string]string{
|
||||
TrackerMilestonesVerb: `{"milestones":[{"design":47,"id":"1","outcome":"A merge is never dropped","status":"open","issues":[973,525]},{"design":47,"id":"2","outcome":"Done thing","status":"done","issues":[1]}]}`,
|
||||
TrackerListVerb: `[{"number":973,"title":"The window","status":"fixing"},{"number":525,"title":"The queue","status":"open"}]`,
|
||||
DeliveryGroupsVerb: `[{"id":"fix/a","state":"held","why":"a member is held","members":["x@1"]}]`,
|
||||
AsksVerb: `{"asks":[{"key":"ask-1","asker":"mesh-knowledge","headline":"Approve ADR 0301","state":"open","offered_on":["telegram"]},{"key":"ask-0","asker":"x","headline":"old","state":"answered"}]}`,
|
||||
}}
|
||||
w.o = NewOverview(func(key string, body any) (json.RawMessage, error) {
|
||||
if w.fail[key] {
|
||||
return nil, errors.New("no answer in time")
|
||||
}
|
||||
return json.RawMessage(w.answers[key]), nil
|
||||
}, func() ([]*Entry, error) { return w.entries, nil }, func() time.Time { return w.now })
|
||||
return w
|
||||
}
|
||||
|
||||
func recordEntry(n int, status, date string, accepted time.Time, mut func(*Record)) *Entry {
|
||||
r := &Record{Kind: KindDecision, Number: n, Title: "Record " + itoa(n), Status: status, Date: date, AcceptedAt: accepted}
|
||||
if mut != nil {
|
||||
mut(r)
|
||||
}
|
||||
return &Entry{Current: r, CurrentVersion: 1, Versions: 1}
|
||||
}
|
||||
|
||||
// The page's model (ADR 0616 §1-3, AC P1): three blocks built from the ledger, the tracker's milestones and issues, the delivery
|
||||
// groups and the operator channel's asks; events change the blocks and ask no verb; a record accepted eight days before the
|
||||
// answer is not in the seven-day block, with no event between.
|
||||
func TestThePageModelHasThreeBlocksKeptByEventsAndAsksNoVerbAgain(t *testing.T) {
|
||||
w := newOverviewWorld(t)
|
||||
w.entries = []*Entry{
|
||||
recordEntry(301, StatusAccepted, "2026-11-02", w.now.Add(-2*24*time.Hour), nil),
|
||||
recordEntry(302, StatusAccepted, "2026-10-20", w.now.Add(-6*24*time.Hour-23*time.Hour), nil),
|
||||
recordEntry(303, StatusProposed, "2026-11-04", time.Time{}, func(r *Record) {
|
||||
r.NeedsOperator = true
|
||||
r.Ask = &OperatorAsk{ID: "a", Said: "waiting"}
|
||||
}),
|
||||
recordEntry(304, StatusProposed, "2026-11-04", time.Time{}, nil),
|
||||
}
|
||||
w.o.Start()
|
||||
m, err := w.o.Model()
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if len(m.Designs) != 1 || m.Designs[0].ID != "1" || len(m.Designs[0].Issues) != 2 || m.Designs[0].Issues[0].Title != "The window" {
|
||||
t.Fatalf("the design block: %+v", m.Designs)
|
||||
}
|
||||
if len(m.Accepted) != 2 || len(m.Waiting) != 2 || len(m.Operator.Records) != 1 || m.Operator.Records[0].Record != "ADR 0303" ||
|
||||
len(m.Operator.Asks) != 1 || m.Operator.Asks[0].Key != "ask-1" || len(m.Operator.Groups) != 1 {
|
||||
t.Fatalf("%+v", m)
|
||||
}
|
||||
asked := map[string]int{}
|
||||
for _, v := range []string{TrackerMilestonesVerb, TrackerListVerb, DeliveryGroupsVerb, AsksVerb} {
|
||||
asked[v] = w.o.Calls(v)
|
||||
}
|
||||
// Events change the blocks.
|
||||
w.o.Heard(SourceDelivery, "mesh-delivery-gate.group", json.RawMessage(`{"group":"fix/b","state":"checking","members":["y@2"]}`))
|
||||
w.o.Heard(SourceDelivery, "mesh-delivery-gate.transition", json.RawMessage(`{"group":"fix/a","to":"approved"}`))
|
||||
w.o.Heard(SourceAsks, "messenger.offered", json.RawMessage(`{"key":"ask-2","asker":"mesh-delivery","headline":"Approve the group","channels":["telegram"]}`))
|
||||
w.o.Heard(SourceTracker, "mesh-issues.opened", json.RawMessage(`{"number":1999,"title":"New","status":"open"}`))
|
||||
w.o.Heard(SourceTracker, "mesh-issues.milestone-moved", json.RawMessage(`{"design":47,"id":"1","to":"done","issues":[973,525,1999]}`))
|
||||
m, _ = w.o.Model()
|
||||
if len(m.Operator.Groups) != 2 || m.Operator.Groups[0].State != "approved" || len(m.Operator.Asks) != 2 || len(m.Designs) != 0 {
|
||||
t.Fatalf("after the events: %+v", m)
|
||||
}
|
||||
w.o.Heard(SourceDelivery, "mesh-delivery-gate.merged", json.RawMessage(`{"group":"fix/a"}`))
|
||||
w.o.Heard(SourceAsks, "messenger.closed", json.RawMessage(`{"key":"ask-1","how":"answered"}`))
|
||||
m, _ = w.o.Model()
|
||||
if len(m.Operator.Groups) != 1 || m.Operator.Groups[0].ID != "fix/b" || len(m.Operator.Asks) != 1 || m.Operator.Asks[0].Key != "ask-2" {
|
||||
t.Fatalf("after merged and closed: %+v", m.Operator)
|
||||
}
|
||||
for v, n := range asked {
|
||||
if w.o.Calls(v) != n {
|
||||
t.Errorf("%s was asked again by an event", v)
|
||||
}
|
||||
}
|
||||
// The seven days are counted when the answer is given: no event between, the record falls out of the block.
|
||||
w.now = w.now.Add(2 * 24 * time.Hour)
|
||||
m, _ = w.o.Model()
|
||||
if len(m.Accepted) != 1 || m.Accepted[0].Record != "ADR 0301" {
|
||||
t.Fatalf("the seven-day block: %+v", m.Accepted)
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user