Measure each fix from the move to fixing to delivered, and say one over its budget (issue 403)

hq ADR 0313: the operator's five minutes start when an agent moves the issue
to fixing, not at the merge. mesh-delivery says on each transition, and in
checks, when the pull request opened, when it merged and the class of what it
moves. mesh-issues keeps the first move to fixing, the fix time with its four
phases once the last fix is delivered, serves fix-times, and says
issue-tracker.fix.<class>.over-budget on the operator's channel, cleared by the
next fix of that class within budget.

modules/mesh-delivery/cmd/mesh-delivery/checks.go

@@ -65,6 +65,11 @@ type ChecksOf struct {
 	Since string `json:"since"`
 	Waits string `json:"waits,omitempty"`
 	Group string `json:"group,omitempty"`
+	// Class, Opened and MergedAt are what the issue tracker measures a fix's time by (novox/hq ADR 0313): the
+	// class of what it moves, when its pull request was first heard, and when it merged.
+	Class    string `json:"class,omitempty"`
+	Opened   string `json:"opened,omitempty"`
+	MergedAt string `json:"merged_at,omitempty"`
 }
 
 // Checks is the `checks` verb: a repository and a pull request's number, or a repository and a commit.
@@ -104,7 +109,13 @@ func (h *Holder) Checks(repository string, number int, commit string) (*ChecksAn
 	}
 	if d != nil {
 		a.Delivery = &ChecksOf{ID: d.ID, State: d.State, Since: d.Since.UTC().Format(time.RFC3339), Waits: d.waits,
-			Group: d.Group}
+			Group: d.Group, Class: fixClass(&d.Delivery)}
+		if !d.opened.IsZero() {
+			a.Delivery.Opened = d.opened.UTC().Format(time.RFC3339)
+		}
+		if !d.MergedAt.IsZero() {
+			a.Delivery.MergedAt = d.MergedAt.UTC().Format(time.RFC3339)
+		}
 		if d.Check != nil && sameCommit(d.Commit, a.Commit) {
 			a.Verdict = d.Check
 		}
@@ -139,6 +150,7 @@ type checksDelivery struct {
 	Delivery
 	waits     string
 	groupSaid string
+	opened    time.Time
 }
 
 // deliveryOf is the delivery of a commit — its head, or the commit it merged as — else, for a pull request,
@@ -167,7 +179,7 @@ func (h *Holder) deliveryOf(repository string, number int, commit string) *check
 	if found == nil {
 		return nil
 	}
-	c := &checksDelivery{Delivery: *found, waits: h.waitsFor(found)}
+	c := &checksDelivery{Delivery: *found, waits: h.waitsFor(found), opened: h.openedOf(found)}
 	if found.Check != nil {
 		v := *found.Check
 		c.Check = &v

modules/mesh-delivery/cmd/mesh-delivery/effects.go

@@ -14,8 +14,10 @@ import (
 // the forge's holder, asked through its tools). Owed, never lost: kept with the delivery before anything is
 // tried, and tried again until done.
 
-// transitionEvent is what `mesh-delivery.transition` says: no secret, no address.
-func transitionEvent(d *Delivery, t Transition) map[string]any {
+// transitionEvent is what `mesh-delivery.transition` says: no secret, no address. opened is when its pull
+// request was first heard (zero when not known); with its class and its merge's moment it is what the issue
+// tracker measures a fix's time by (novox/hq ADR 0313 §2, §4).
+func transitionEvent(d *Delivery, t Transition, opened time.Time) map[string]any {
 	e := map[string]any{"id": d.ID, "repository": d.Repository, "commit": d.Commit, "from": t.From, "to": t.To,
 		"event": t.Event, "why": t.Why, "at": t.At}
 	if t.By != "" {
@@ -36,9 +38,57 @@ func transitionEvent(d *Delivery, t Transition) map[string]any {
 	if d.Plan != nil {
 		e["plan"] = d.Plan.Summary
 	}
+	if c := fixClass(d); c != "" {
+		e["class"] = c
+	}
+	if !opened.IsZero() {
+		e["opened"] = opened.UTC()
+	}
+	if !d.MergedAt.IsZero() {
+		e["merged_at"] = d.MergedAt.UTC()
+	}
 	return e
 }
 
+// fixClass is the class of what a delivery moves (novox/hq ADR 0313 §2): its plan's, as the planner said it;
+// none for a plan that moves no module, from a planner that did not say a class; else its walk's class once its
+// delivery time is known; empty when nothing says it.
+func fixClass(d *Delivery) string {
+	switch {
+	case d.Plan != nil && d.Plan.Class != "":
+		return d.Plan.Class
+	case d.Plan != nil && len(d.Plan.Moved) == 0 && len(d.Plan.Dependents) == 0 && len(d.Plan.New) == 0:
+		return classNone
+	case d.Time != nil:
+		return d.Time.Class
+	}
+	return ""
+}
+
+// classNone is the class of a delivery that moves no module: nothing for a walk to move, and no fix budget.
+const classNone = "none"
+
+// openedOf is when a delivery's pull request was first heard: the earliest head of it this owner holds, never
+// one made from the forge's word at its merge; zero when none is held or it has no pull request. Under the lock.
+func (h *Holder) openedOf(d *Delivery) time.Time {
+	if d.Number <= 0 {
+		return time.Time{}
+	}
+	var first time.Time
+	for _, c := range h.deliveries {
+		if c.FromForge || c.Number != d.Number || !strings.EqualFold(c.Repository, d.Repository) || c.Created.IsZero() {
+			continue
+		}
+		if first.IsZero() || c.Created.Before(first) {
+			first = c.Created
+		}
+	}
+	if first.IsZero() && !d.FromForge {
+		first = d.Created
+	}
+	return first
+}
+
 // noteLine is one transition as the commit's note keeps it.
 func noteLine(d *Delivery, t Transition) string {
 	by := ""

modules/mesh-delivery/cmd/mesh-delivery/holder.go

@@ -172,9 +172,10 @@ func (h *Holder) refuse(err error) {
 // moved records what a delivery's transitions owe outside, and keeps it.
 func (h *Holder) moved(d *Delivery, ts []Transition) {
 	now := h.Now()
+	opened := h.openedOf(d)
 	for _, t := range ts {
 		h.Logf("[mesh-delivery] %s: %s → %s (%s): %s", d.ID, orNothing(t.From), t.To, t.Event, t.Why)
-		d.Owed = append(d.Owed, Effect{Kind: EffectEmit, Line: string(mustJSON(transitionEvent(d, t))), Since: now})
+		d.Owed = append(d.Owed, Effect{Kind: EffectEmit, Line: string(mustJSON(transitionEvent(d, t, opened))), Since: now})
 		line := noteLine(d, t)
 		d.Owed = append(d.Owed, Effect{Kind: EffectNote, Commit: d.Commit, Line: line, Since: now})
 		if d.MergedAs != "" && !sameCommit(d.MergedAs, d.Commit) && afterTheTrunk(t.To) {

modules/mesh-delivery/cmd/mesh-delivery/issue403_test.go

@@ -0,0 +1,95 @@
+package main
+
+import (
+	"testing"
+	"time"
+)
+
+// novox/hq issue 403, ADR 0313: the issue tracker measures a fix's time from the move to fixing to delivered and
+// splits it at the pull request's opening and its merge. A transition says what it reads them by: when the pull
+// request was first heard (its first head, not a later one), when it merged, and the class of what it moves —
+// core, leaf, or none for a change that moves no module. `checks` says the same for a fix the tracker hears of late.
+
+// transitionsTo are the transition events said for a delivery that moved to a state.
+func transitionsTo(w *world, id string, to State) []map[string]any {
+	var out []map[string]any
+	for _, e := range w.said {
+		if e["event-kind"] == "transition" && e["id"] == id && e["to"] == string(to) {
+			out = append(out, e)
+		}
+	}
+	return out
+}
+
+func TestATransitionSaysWhenItsPullRequestOpenedMergedAndItsClass(t *testing.T) {
+	w := newWorld(t)
+	repo := "novox/mesh-catalog"
+	opened := w.now
+	first := pr(repo, 9, "head9first", "fix/403-x", "modules/app/a.go")
+	w.h.PullUpdated(first)
+	w.later(3 * time.Minute)
+	second := pr(repo, 9, "head9second", "fix/403-x", "modules/app/a.go")
+	w.h.PullUpdated(second)
+	c := verdictMoving(repo, 9, "head9second", "app")
+	c.Plan.Class = "core"
+	w.h.Checked(c)
+	w.later(2 * time.Minute)
+	mergedWhen := w.now
+	w.h.PullMerged(mergedAt(second, "merge9aaaaaa", mergedWhen))
+	walk := aWalk("plan-merge9", repo, "merge9aaaaaa", false)
+	walk.Delivery = &WalkDelivery{Merges: []WalkMerge{{Repository: repo, Commit: "merge9aaaaaa"}}}
+	w.h.WalkMoved(w.ctl.put(walk))
+	w.settleAll()
+	walk = w.ctl.walk(walk.ID)
+	walk.State, walk.Revision = walkDone, walk.Revision+1
+	walk.Modules = map[string]*WalkModule{"app": {State: "built"}}
+	w.h.WalkMoved(w.ctl.put(walk))
+	w.settleAll()
+
+	id := IDOf(repo, "head9second")
+	if s := w.state(id); s != Delivered {
+		t.Fatalf("the merge is %s, not delivered", s)
+	}
+	said := transitionsTo(w, id, Delivered)
+	if len(said) == 0 {
+		t.Fatalf("no transition to delivered was said: %v", w.said)
+	}
+	e := said[len(said)-1]
+	if e["opened"] != opened.UTC().Format(time.RFC3339) {
+		t.Errorf("opened %v, want the first head's %s (not the second head's)", e["opened"], opened.Format(time.RFC3339))
+	}
+	if e["merged_at"] != mergedWhen.UTC().Format(time.RFC3339) {
+		t.Errorf("merged_at %v, want %s", e["merged_at"], mergedWhen.Format(time.RFC3339))
+	}
+	if e["class"] != "core" {
+		t.Errorf("class %v, want the plan's core", e["class"])
+	}
+
+	a, err := w.h.Checks(repo, 9, "")
+	if err != nil {
+		t.Fatal(err)
+	}
+	if a.Delivery == nil || a.Delivery.Opened != opened.UTC().Format(time.RFC3339) || a.Delivery.Class != "core" ||
+		a.Delivery.MergedAt != mergedWhen.UTC().Format(time.RFC3339) {
+		t.Errorf("checks says %+v", a.Delivery)
+	}
+}
+
+// A plan that moves no module is class none, so the tracker gives its fix no budget; a plan from a controller that
+// says no class falls back to its walk's class once known, and says nothing before.
+func TestAFixClassIsNoneWhenItMovesNothing(t *testing.T) {
+	for _, c := range []struct {
+		why  string
+		d    Delivery
+		want string
+	}{
+		{"the planner's class", Delivery{Plan: &DeliveryPlan{Moved: []string{"app"}, Class: "leaf"}}, "leaf"},
+		{"a plan that moves nothing, no class said", Delivery{Plan: planMoving("novox/x")}, "none"},
+		{"no class said, its walk's known", Delivery{Plan: planMoving("novox/x", "app"), Time: &DeliveryTime{Class: "core"}}, "core"},
+		{"no class said, nothing known", Delivery{Plan: planMoving("novox/x", "app")}, ""},
+	} {
+		if got := fixClass(&c.d); got != c.want {
+			t.Errorf("%s: %q, want %q", c.why, got, c.want)
+		}
+	}
+}

modules/mesh-delivery/cmd/mesh-delivery/model.go

@@ -165,6 +165,9 @@ type DeliveryPlan struct {
 	Machines   []MachinePlan `json:"machines,omitempty"`
 	Steps      []string      `json:"steps,omitempty"`
 	Summary    string        `json:"summary"`
+	// Class is the class of the slowest-budgeted module it moves, as the planner says it: core, leaf, or none when
+	// it moves no module (novox/hq ADR 0313 §2). Empty in a plan from a controller that did not say it.
+	Class string `json:"class,omitempty"`
 }
 
 // receiving are the machines the plan sends a module to, in the plan's order; none when the plan names no