A graduated closing is judged on every became link the effort carries, carried ones too, each with its record's title and status (issue 784, ADR 0630 §2)
mesh/delivery merged: source.main moved to novox/mesh-catalog@8acad77d33f9
mesh/check being carried to 46505d42d8fb on 8acad77d33f9 | from d2f326dff40e
mesh/delivery merged: source.main moved to novox/mesh-catalog@8acad77d33f9
mesh/check being carried to 46505d42d8fb on 8acad77d33f9 | from d2f326dff40e
Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn
This commit is contained in:
@@ -225,8 +225,8 @@ func (r *Record) hasSectionNamed(name string) bool {
|
||||
}
|
||||
|
||||
// ClosingQuestion is the review's question for a closing (ADR 0630 §2): the record's number and title, the status it
|
||||
// is served at and the move, the closing's section and the links it adds with the linked records' titles and
|
||||
// statuses, and never the effort's old sections. linked are the records the added links name.
|
||||
// is served at and the move, the closing's section and the links it judges (ClosingLinks) with the linked records' titles and
|
||||
// statuses, and never the effort's old sections. linked are the records ClosingLinks name.
|
||||
func ClosingQuestion(r *Record, from string, linked []*Record) string {
|
||||
c := r.Pending.Closing
|
||||
var b strings.Builder
|
||||
@@ -244,11 +244,17 @@ func ClosingQuestion(r *Record, from string, linked []*Record) string {
|
||||
}
|
||||
b.WriteString(" Answer changes otherwise, with findings, each naming the note or the link and saying what to change. " +
|
||||
"Do not ask for changes of taste or wording that leave the meaning as it is.\n\n")
|
||||
fmt.Fprintf(&b, "The note, section %q:\n\n%s\n\nThe links the closing adds:\n", c.Section, c.Note)
|
||||
if len(c.Added) == 0 {
|
||||
fmt.Fprintf(&b, "The note, section %q:\n\n%s\n\n", c.Section, c.Note)
|
||||
if c.To == StatusGraduated {
|
||||
b.WriteString("The became links the effort carries, those it carried before and those the closing adds:\n")
|
||||
} else {
|
||||
b.WriteString("The links the closing adds:\n")
|
||||
}
|
||||
shown := ClosingLinks(r)
|
||||
if len(shown) == 0 {
|
||||
b.WriteString("- none\n")
|
||||
}
|
||||
for _, l := range c.Added {
|
||||
for _, l := range shown {
|
||||
fmt.Fprintf(&b, "- %s\n", l)
|
||||
}
|
||||
if len(linked) > 0 {
|
||||
@@ -259,3 +265,20 @@ func ClosingQuestion(r *Record, from string, linked []*Record) string {
|
||||
}
|
||||
return b.String()
|
||||
}
|
||||
|
||||
// ClosingLinks are the links a closing's review judges (ADR 0630 §2): for a closing to graduated every became link
|
||||
// the record carries, carried before or added, since each must name an accepted record; otherwise the links the
|
||||
// closing adds.
|
||||
func ClosingLinks(r *Record) []Link {
|
||||
c := r.Pending.Closing
|
||||
if c.To != StatusGraduated {
|
||||
return c.Added
|
||||
}
|
||||
var out []Link
|
||||
for _, l := range r.Links {
|
||||
if l.Kind == LinkBecame {
|
||||
out = append(out, l)
|
||||
}
|
||||
}
|
||||
return out
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user