mesh-build-image: let the module's own guard decide whether the real-buildah tests run, so a check sandbox where rootless buildah cannot unshare skips them loudly instead of failing every catalogue check (issue 1894)
mesh/delivery delivered
mesh/delivery-group group fix/1839-build-floor delivered: every member is delivered
mesh/check failed: g14: the check ran past its bound of 30m0s, stuck at: test the integration level of novox/mesh-catalog#458 on g14 | 539a31103b53 on…

This commit is contained in:
2026-10-23 12:38:09 +02:00
parent 3ca48ff230
commit 539a31103b
@@ -53,6 +53,11 @@ func realModule(t *testing.T) (*Module, *keptStates) {
m := &Module{Node: "ace", Account: u.Username, UID: u.Uid, Home: home, Work: t.TempDir(), Store: t.TempDir(),
Steps: states.putStep, Ctx: context.Background(), Say: t.Logf, Run: StepRunner(home),
FetchOptions: []buildstep.Option{buildstep.AllowFileRemote()}}
// buildah being installed is not enough: inside the check's sandbox rootless buildah cannot make its user
// namespace, so the module's own guard decides, as it does before every step (issue 1894).
if err := m.Check(context.Background()); err != nil {
t.Skipf("NOT RUN: this machine cannot build images where the check runs (%v); proven live on a build node", err)
}
return m, states
}