From 55a88cdba4e54696f718dd4b67e54f6b46d860a7 Mon Sep 17 00:00:00 2001 From: jochen Date: Wed, 4 Nov 2026 14:34:40 +0100 Subject: [PATCH] Drop a holds test that passes without its change; the propose description names the limit's setting Round 2 of issue 1970's review: a research effort has no clauses, so holds never serves one; Served on an idea is tested in TestAnIdeaIsListedAndNeverServedAsTruth. Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn --- modules/mesh-knowledge/cmd/mesh-knowledge/idea_test.go | 10 ---------- modules/mesh-knowledge/cmd/mesh-knowledge/main.go | 2 +- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/modules/mesh-knowledge/cmd/mesh-knowledge/idea_test.go b/modules/mesh-knowledge/cmd/mesh-knowledge/idea_test.go index b4bfcb24..b92c2654 100644 --- a/modules/mesh-knowledge/cmd/mesh-knowledge/idea_test.go +++ b/modules/mesh-knowledge/cmd/mesh-knowledge/idea_test.go @@ -69,16 +69,6 @@ func TestAtMostThreeResearchEffortsAreActive(t *testing.T) { } } -// ADR 0629 §2: holds answers nothing from an idea. -func TestHoldsAnswersNothingFromAnIdea(t *testing.T) { - w := imported(t, newMemStore()) - k := Key{KindResearch, w.effort(t, StatusIdea)} - h, err := w.k.Holds("", &k, 0) - if err != nil || len(h.Clauses) != 0 { - t.Fatalf("holds from an idea: %+v, %v", h, err) - } -} - // ADR 0629 §1, §2: list at idea is the roadmap; ask, holds and get never answer an idea as a record in force. func TestAnIdeaIsListedAndNeverServedAsTruth(t *testing.T) { w := imported(t, newMemStore()) diff --git a/modules/mesh-knowledge/cmd/mesh-knowledge/main.go b/modules/mesh-knowledge/cmd/mesh-knowledge/main.go index 79aa4e12..f0b70606 100644 --- a/modules/mesh-knowledge/cmd/mesh-knowledge/main.go +++ b/modules/mesh-knowledge/cmd/mesh-knowledge/main.go @@ -974,7 +974,7 @@ func Tools(k *KB, caller func(map[string]any) string) []stdio.Tool { "links (supersedes, changes \"0276 §4\", extends, became, cites), and whether it needs the operator, with the brief its ask shows. Refused, naming " + "every reason at once and writing nothing, when it breaks one of the 30 rules that judge one record or its prose — a " + "link to nothing, a clause without a bold lead, a superseded record cited alone, an unknown topic, a retired word. A " + - "proposal is revised by proposing it again; an accepted record (an active research effort or an idea excepted, which take new versions; at most three research efforts are active) changes only by a progressive insight (insight: what " + + "proposal is revised by proposing it again; an accepted record (an active research effort or an idea excepted, which take new versions; at most as many research efforts are active as the setting research-active-at-most allows, three by default) changes only by a progressive insight (insight: what " + "stood before). The knowledge base then reviews each version itself, in a judgement that sees only the record, the " + "records it links and the rules. A decision that names no home and that no accepted record links is not judged: " + "its review asks changes for the whole-set rule cited, which its acceptance would break. On approve it is accepted (a record that needs the operator waits for the operator's " +