From 5ccce4967a98e2e368f9e24558574f829999eaa9 Mon Sep 17 00:00:00 2001 From: jochen Date: Sun, 1 Nov 2026 17:26:58 +0100 Subject: [PATCH] Keep three timeout tests' upper bounds well under the production timeouts, so a timeout that falls back to production still fails (issue 1814, review round 3) Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL --- modules/claude-code/cmd/claude-code/agent_account_test.go | 2 +- modules/claude-code/cmd/claude-code/judge_test.go | 2 +- modules/zfs/cmd/zfs-tools/review_test.go | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/modules/claude-code/cmd/claude-code/agent_account_test.go b/modules/claude-code/cmd/claude-code/agent_account_test.go index 60af230b..ec597b7b 100644 --- a/modules/claude-code/cmd/claude-code/agent_account_test.go +++ b/modules/claude-code/cmd/claude-code/agent_account_test.go @@ -567,7 +567,7 @@ func TestAHelperThatDoesNotAnswerFailsTheRequestInTime(t *testing.T) { if err == nil || !errors.Is(err, errHelperSlow) { t.Fatalf("a silent helper answered: %v", err) } - if time.Since(start) > 30*time.Second { + if time.Since(start) > 10*time.Second { t.Fatalf("the request waited %s", time.Since(start)) } } diff --git a/modules/claude-code/cmd/claude-code/judge_test.go b/modules/claude-code/cmd/claude-code/judge_test.go index 0f714872..4fd3da1f 100644 --- a/modules/claude-code/cmd/claude-code/judge_test.go +++ b/modules/claude-code/cmd/claude-code/judge_test.go @@ -133,7 +133,7 @@ func TestAJudgementWaitsItsTurnWithinTheBound(t *testing.T) { if err == nil || !strings.Contains(err.Error(), "another judgement") { t.Fatalf("%v", err) } - if time.Since(start) > 30*time.Second { + if time.Since(start) > 10*time.Second { t.Fatal("waited past the bound") } } diff --git a/modules/zfs/cmd/zfs-tools/review_test.go b/modules/zfs/cmd/zfs-tools/review_test.go index 0eda82f4..8d8408b1 100644 --- a/modules/zfs/cmd/zfs-tools/review_test.go +++ b/modules/zfs/cmd/zfs-tools/review_test.go @@ -29,8 +29,8 @@ func TestATimedOutCommandIsEndedWithItsChildren(t *testing.T) { ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second) // long enough for a loaded machine to start the shell and write the pid defer cancel() start := time.Now() - r := ExecRunner(ctx, "sh", "-c", "sleep 30 & echo $! > "+pidFile+"; wait") - if took := time.Since(start); took > 30*time.Second { + r := ExecRunner(ctx, "sh", "-c", "sleep 300 & echo $! > "+pidFile+"; wait") + if took := time.Since(start); took > 10*time.Second { t.Fatalf("the call waited %s for a child holding its output", took) } if !r.TimedOut {