Name no node in brother's and keycloak's fixtures (issue 1838)

modules/keycloak/cmd/keycloak-provider/admin_test.go

@@ -52,7 +52,7 @@ type guardWorld struct {
 
 func newGuardWorld(t *testing.T) *guardWorld {
 	w := &guardWorld{now: time.Date(2026, 10, 5, 23, 55, 0, 0, time.UTC)}
-	w.f = newFakeKeycloak(t, "Novox", "old-password-from-2022")
+	w.f = newFakeKeycloak(t, "NodeC", "old-password-from-2022")
 	w.x = &fakeExec{f: w.f}
 	w.g = &Guard{KC: w.f.client("the-mesh-minted-this"), Exec: w.x,
 		Now:      func() time.Time { return w.now },
@@ -195,7 +195,7 @@ func TestWhileTheAdminIsRefusedTheProvisionerDoesNotAskKeycloak(t *testing.T) {
 	w := newGuardWorld(t)
 	w.x.fails = true
 	w.g.Ensure(ctx, true, false)
-	a := provisioner{clients: OidcClients{KC: w.g.KC, Realm: "Novox"}, guard: w.g,
+	a := provisioner{clients: OidcClients{KC: w.g.KC, Realm: "NodeC"}, guard: w.g,
 		announce: func(string, map[string]any) {}, log: func(string, ...any) {}}
 	logins := w.f.logins
 	err := a.Create(ctx, grafana("s", nil))

modules/keycloak/cmd/keycloak-provider/grant_moved_test.go

@@ -91,13 +91,13 @@ func movedWorld(t *testing.T, h *harness.Harness) (f *fakeKeycloak, start func()
 	}
 }
 
-// 1332/AC1: a consumer only the grant file gives (oidc-client for novox.mesh-mail-web, not moved) is wanted and
+// 1332/AC1: a consumer only the grant file gives (oidc-client for node-c.mesh-mail-web, not moved) is wanted and
 // Adapter.Create is asked for its client, though keycloak runs on the moved path.
 func TestAGrantFileConsumerNotMovedIsMadeOnTheMovedPath(t *testing.T) {
-	mailWeb := "mesh_novox_mail_web"
-	receives := grantGives(t, map[string]any{"as": mailWeb, "node": "novox", "values": map[string]any{
+	mailWeb := "mesh_node_c_mail_web"
+	receives := grantGives(t, map[string]any{"as": mailWeb, "node": "node-c", "values": map[string]any{
 		"label": "mail-web", "endpoint": "web", "callback": "/login/generic_oauth", "name": "mail.example.org"}})
-	h := &harness.Harness{Resource: ProvisionName, Receives: receives, Node: "novox"}
+	h := &harness.Harness{Resource: ProvisionName, Receives: receives, Node: "node-c"}
 	f, start := movedWorld(t, h)
 	start()
 	waitUntil(t, time.Second, func() bool {
@@ -113,13 +113,13 @@ func TestAGrantFileConsumerNotMovedIsMadeOnTheMovedPath(t *testing.T) {
 	})
 }
 
-// 1332/AC2: a grant-file consumer whose client already exists in the backend (mesh_ace_grafana) counts as asked and
+// 1332/AC2: a grant-file consumer whose client already exists in the backend (mesh_node_a_grafana) counts as asked and
 // is not held for retirement on the moved path.
 func TestAGrantFileConsumerAlreadyInKeycloakIsNotRetiredOnTheMovedPath(t *testing.T) {
-	grafana := "mesh_ace_grafana"
-	receives := grantGives(t, map[string]any{"as": grafana, "node": "ace", "values": map[string]any{
+	grafana := "mesh_node_a_grafana"
+	receives := grantGives(t, map[string]any{"as": grafana, "node": "node-a", "values": map[string]any{
 		"label": "grafana", "endpoint": "web", "callback": "/login/generic_oauth", "name": "grafana.example.org"}})
-	h := &harness.Harness{Resource: ProvisionName, Receives: receives, Node: "ace",
+	h := &harness.Harness{Resource: ProvisionName, Receives: receives, Node: "node-a",
 		StablePasses: 1, StableFor: time.Millisecond}
 	f, start := movedWorld(t, h)
 	// Seed the backend with the client the mesh made earlier, exactly as grafana's already is — before anything

modules/keycloak/cmd/keycloak-provider/main_test.go

@@ -8,7 +8,7 @@ import "testing"
 // 1332/AC3: the moved-path harness, built from the environment, reads MESH_RECEIVES the way the grant path does
 // (main.go's other branch, line 67), as postgres's moved harness does (postgres-provider/main.go:43).
 func TestTheMovedPathHarnessReadsMESH_RECEIVESAsTheGrantPathDoes(t *testing.T) {
-	env := map[string]string{"MESH_RECEIVES": "/grants/mesh.json", "MESH_NODE": "novox"}
+	env := map[string]string{"MESH_RECEIVES": "/grants/mesh.json", "MESH_NODE": "node-c"}
 	getenv := func(k string) string { return env[k] }
 	h := movedHarness(getenv, provisioner{})
 	if h.Receives != env["MESH_RECEIVES"] {

modules/keycloak/cmd/keycloak-provider/moved_test.go

@@ -14,7 +14,7 @@ import (
 	"git.novox.be/novox/mesh-sdk/go/provider/harness"
 )
 
-const testIssuer = "https://id.example.org/realms/Novox"
+const testIssuer = "https://id.example.org/realms/NodeC"
 
 // keycloak's own part of the moved path (issue 849): the shared driving of it is proven in the SDK's harness package.
 
@@ -143,12 +143,12 @@ func TestBothPathsLeaveTheSameClientInKeycloak(t *testing.T) {
 	})
 	viaFile := made(func(p provisioner) {
 		list, _ := json.Marshal([]provider.ConsumerCredential{{Consumer: "home", Module: "grafana",
-			Credential: provider.PairName("novox", ProvisionName, "home", "grafana", ""), Value: "pw-" + grafana}})
+			Credential: provider.PairName("node-c", ProvisionName, "home", "grafana", ""), Value: "pw-" + grafana}})
 		file := filepath.Join(t.TempDir(), "consumers.json")
 		if err := os.WriteFile(file, list, 0o600); err != nil {
 			t.Fatal(err)
 		}
-		h := &harness.Harness{Resource: ProvisionName, Adapter: p, Node: "novox",
+		h := &harness.Harness{Resource: ProvisionName, Adapter: p, Node: "node-c",
 			Now: func() time.Time { return now }, Log: func(string, ...any) {}}
 		run, _, _, err := moved(file, h, testIssuer)
 		if err != nil {
@@ -156,10 +156,10 @@ func TestBothPathsLeaveTheSameClientInKeycloak(t *testing.T) {
 		}
 		bus := &bucketBus{buckets: map[string]map[string][]byte{}}
 		plan, _ := json.Marshal(map[string]any{"node": "home", "module": "grafana", "provisioning": map[string]any{
-			"provisions": []any{map[string]any{"provision": ProvisionName, "provider": "novox",
+			"provisions": []any{map[string]any{"provision": ProvisionName, "provider": "node-c",
 				"provider-module": "keycloak", "contributes": grafanaContributes, "names": grafanaNames}}}})
 		_ = bus.Put(ctx, provider.AssignmentsBucket, "home.grafana", plan)
-		pr := provider.New(provider.Options{Node: "novox", Module: "keycloak", Bus: bus,
+		pr := provider.New(provider.Options{Node: "node-c", Module: "keycloak", Bus: bus,
 			Vault: provider.ConsumersFile{Paths: []string{file}},
 			Offers: map[string]provider.Offer{ProvisionName: {Credential: provider.PerConsumer,
 				Serves: servedValues(testIssuer)}},

modules/keycloak/cmd/keycloak-provider/oidc.go

@@ -64,7 +64,7 @@ func RolesMapper() Rep {
 
 var realmPath = regexp.MustCompile(`/realms/([^/]+)/?$`)
 
-// RealmOf is the realm named by an issuer URL — `https://id.example/realms/Novox` is realm `Novox`.
+// RealmOf is the realm named by an issuer URL — `https://id.example/realms/NodeC` is realm `NodeC`.
 // The issuer is the one value an assignment sets, so the realm is read out of it rather than set a
 // second time where the two could disagree.
 func RealmOf(issuer string) (string, error) {

modules/keycloak/cmd/keycloak-provider/oidc_test.go

@@ -15,8 +15,8 @@ import (
 )
 
 func oidcWorld(t *testing.T) (*fakeKeycloak, OidcClients) {
-	f := newFakeKeycloak(t, "Novox", "pw")
-	return f, OidcClients{KC: f.client("pw"), Realm: "Novox"}
+	f := newFakeKeycloak(t, "NodeC", "pw")
+	return f, OidcClients{KC: f.client("pw"), Realm: "NodeC"}
 }
 
 // grafana is a dashboard on the home server, as the mesh hands it to the provisioner.
@@ -53,8 +53,8 @@ func mustHold(t *testing.T, o OidcClients, p harness.Provision, want bool) {
 
 func TestTheRealmIsReadOutOfTheIssuer(t *testing.T) {
 	for issuer, want := range map[string]string{
-		"https://id.example.org/realms/Novox":  "Novox",
-		"https://id.example.org/realms/Novox/": "Novox",
+		"https://id.example.org/realms/NodeC":  "NodeC",
+		"https://id.example.org/realms/NodeC/": "NodeC",
 		"http://127.0.0.1:18500/realms/master": "master",
 	} {
 		if got, err := RealmOf(issuer); err != nil || got != want {