Ask the Approve as soon as the checks pass, with no ready mark (issue 1022)

The review finishes before the push and its record is a Reviewed-by line in the
description, so the mark repeated what the push meant. mesh-delivery asks the
operator when a pull request's checks pass, keeps an ask through a trunk move
by asking the check again at once, and hands the merge tool the approved heads,
which replace the forge review of each sibling.

modules/gitea/module.json

@@ -169,12 +169,6 @@
       "description": "The read teams of the agents' forge accounts (ADR 0365 clause 3): each team by name, {\"<team>\": {\"repos\": [\"<owner>/<repo>\", ...], \"members\": [\"<node>\", ...]}}. The forge gets a team agent-read-<team> that reads only, with exactly those repositories and the accounts agent-<node>; a team taken out of the value is emptied. Nothing else on the forge is touched; an agent account is in no team until it is listed here.",
       "trusted": true,
       "default": {}
-    },
-    "ready-authors": {
-      "type": "string",
-      "description": "the forge accounts whose comment \"ready at <full head sha>\" marks a pull request ready for mesh-delivery to merge, separated by spaces: the account the forge's tools act as (novox/hq ADR 0365), the admin account for marks made before the tools acted as their own, and the operator's (novox/hq issue 722). A comment by any other account is ignored and said in the forge's log. Trusted: who may have a change merged is the operator's word",
-      "trusted": true,
-      "default": "mesh-tools mesh-admin jschoubben"
     }
   },
   "facts": {
@@ -198,14 +192,6 @@
       "mode": "0700",
       "unknown": "program"
     },
-    {
-      "id": "ready-authors",
-      "type": "file",
-      "path": "${dir:mesh-state}/ready-authors",
-      "mode": "0600",
-      "trusted": true,
-      "template": "files/ready-authors"
-    },
     {
       "id": "forge-patches",
       "type": "directory",
@@ -402,7 +388,6 @@
           "MESH_GITEA_TOOLS_USER": "mesh-tools",
           "MESH_GITEA_STATE_DIR": "${dir:runtime-state}",
           "MESH_RECEIVES": "${dir:grants}/npm.json",
-          "MESH_GITEA_READY_AUTHORS_FILE": "${dir:mesh-state}/ready-authors",
           "MESH_GITEA_HOOK_URL": "http://172.17.0.1:3047",
           "MESH_GITEA_HOOK_PORT": "3047",
           "MESH_GITEA_HOOK_HOST": "172.17.0.1"