Keep a bus account in the vault only as an account: a random value for a broker name is not issued (issue 774)
own/novox/nats/broker-nats-tools (moved in today) and mesh-controller's broker-address and broker-management (moved in from the controller's store) are random values, not the account JSON a bus user is hashed from, so the hash step says "not JSON" and the grants part leaves those users off the bus. The controller made them (fixed there, c421629f); the vault kept them, since nothing it keeps judged a covered name's value. Quick fix: refuse a plain value in move-in. Thorough fix: keepLocked, which every way into the store passes, refuses for any covered name (broker, provisioner-broker, broker-<binary>, which catalogue.ToolsBusSecret names) a value that is no account, saying "not issued". Chose thorough: one rule where every value is kept.
This commit is contained in:
@@ -41,7 +41,11 @@ func TestANodeEngineStatesItsOwnKeyAndAChangeRaisesItsCoreSecrets(t *testing.T)
|
||||
{Node: "ace", Module: "postgres", Name: "superuser-password", Origin: "made", Generation: "g-1"},
|
||||
{Node: "g14", Module: "nats", Name: "broker", Origin: "made", Generation: "g-1"},
|
||||
} {
|
||||
if _, err := moveIn(t, v, "node."+m.Node, m, movedValue); err != nil {
|
||||
value := movedValue
|
||||
if m.Name != "superuser-password" {
|
||||
value = brokerValue // a bus account is kept only as one
|
||||
}
|
||||
if _, err := moveIn(t, v, "node."+m.Node, m, value); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user