mesh-knowledge: bound every review failure per record, make one out of tries loud, and let only its author revise a pending insight (review of #211)

modules/mesh-knowledge/cmd/mesh-knowledge/main.go

@@ -474,8 +474,9 @@ type HealthAnswer struct {
 	At      time.Time `json:"at,omitempty"`
 }
 
-// Health is how the knowledge base is: unhealthy when its database cannot serve, or when a rule that judges the
-// whole record set fails — the mesh raises a condition naming the rule and the records.
+// Health is how the knowledge base is: unhealthy when its database cannot serve, when a rule that judges the
+// whole record set fails, or when a proposed record ran out of review tries — the mesh raises a condition naming
+// the rule, the records, or the records not reviewed.
 func (k *KB) Health(ready Healther) HealthAnswer {
 	ctx, cancel := context.WithTimeout(context.Background(), 8*time.Second)
 	defer cancel()
@@ -488,25 +489,42 @@ func (k *KB) Health(ready Healther) HealthAnswer {
 	if err != nil {
 		return HealthAnswer{State: "unhealthy", Why: "the whole-set findings cannot be read: " + err.Error()}
 	}
-	if len(findings) > 0 {
-		var says []string
-		for _, f := range findings {
-			says = append(says, "the rule "+f.Rule+": "+f.Says)
-		}
-		sort.Strings(says)
-		if len(says) > 8 {
-			says = append(says[:8], fmt.Sprintf("and %d more", len(says)-8))
-		}
-		return HealthAnswer{State: "unhealthy", Why: fmt.Sprintf("%d rule(s) that judge the whole record set fail: %s", len(findings), strings.Join(says, "; "))}
+	var says []string
+	for _, f := range findings {
+		says = append(says, "the rule "+f.Rule+": "+f.Says)
 	}
-	return HealthAnswer{State: "healthy", Healthy: true, Why: "the database serves, and every rule that judges the whole record set holds"}
+	sort.Strings(says)
+	all, err := k.Store.All(ctx)
+	if err != nil {
+		return HealthAnswer{State: "unhealthy", Why: "the records cannot be read: " + err.Error()}
+	}
+	unreviewed := Unreviewed(all)
+	if len(findings)+len(unreviewed) > 0 {
+		var parts []string
+		if len(unreviewed) > 0 {
+			if len(unreviewed) > 8 {
+				unreviewed = append(unreviewed[:8], fmt.Sprintf("and %d more", len(unreviewed)-8))
+			}
+			parts = append(parts, fmt.Sprintf("%d proposed record(s) could not be reviewed in %d tries and wait for their authors to propose them again: %s",
+				len(Unreviewed(all)), MostReviewTries, strings.Join(unreviewed, "; ")))
+		}
+		if len(says) > 0 {
+			if len(says) > 8 {
+				says = append(says[:8], fmt.Sprintf("and %d more", len(says)-8))
+			}
+			parts = append(parts, fmt.Sprintf("%d rule(s) that judge the whole record set fail: %s", len(findings), strings.Join(says, "; ")))
+		}
+		return HealthAnswer{State: "unhealthy", Why: strings.Join(parts, ". ")}
+	}
+	return HealthAnswer{State: "healthy", Healthy: true, Why: "the database serves, every rule that judges the whole record set holds, and no proposal ran out of review tries"}
 }
 
 func healthTool(status string, now func() time.Time) stdio.Tool {
 	return stdio.Tool{Name: HealthTool,
 		Description: "How the knowledge base is, as its watch last saw it: healthy when its database serves this version and every " +
 			"rule that judges the whole record set holds; unhealthy otherwise, naming the rule and the records — a decision accepted " +
-			"that nothing cites, a supersession or a change said on one end only, a record extending a superseded one.",
+			"that nothing cites, a supersession or a change said on one end only, a record extending a superseded one — or when a " +
+			"proposed record ran out of review tries, naming it.",
 		Run: func(map[string]any) (any, error) { return ReadStatus(status, now()), nil }}
 }