mesh-knowledge: bound every review failure per record, make one out of tries loud, and let only its author revise a pending insight (review of #211)

2026-10-11 12:41:24 +02:00
parent ebba63d71f
commit 6fb827605a
6 changed files with 242 additions and 25 deletions
@@ -131,17 +131,23 @@ func newAskID(r *Record) string {
 }

 // askOperator asks the operator to approve a record the knowledge base's review approved, and keeps the ask with
-// it. The caller holds the write lock. An ask that could not be published is taken back, and the review is asked
-// again after a pause: the record stays proposed.
-func (k *KB) askOperator(ctx context.Context, held *Entry, w *Record, by string) (string, error) {
+// it. The caller holds the write lock. An ask that could not be made or published is taken back, and the review is
+// asked again after a pause, counted with the tries before it (tries): the record stays proposed, and is reviewed
+// at most MostReviewTries times.
+func (k *KB) askOperator(ctx context.Context, held *Entry, w *Record, by string, tries int) (string, error) {
 	version := held.CurrentVersion
 	if held.Pending != nil {
 		version = held.PendingVersion
 	}
 	unasked := func(why string) (string, error) {
 		w.Ask = nil
-		w.Judging = &Judging{State: JudgingFailed, Tries: 1, Reason: why, At: k.now()}
-		said := "approved by the knowledge base's review, and " + why + "; it stays proposed and is reviewed again"
+		w.Judging = &Judging{State: JudgingFailed, Tries: tries + 1, Reason: why, At: k.now()}
+		said := fmt.Sprintf("approved by the knowledge base's review, and %s (try %d of %d); it stays proposed", why, tries+1, MostReviewTries)
+		if tries+1 >= MostReviewTries {
+			said += ", and its author proposes it again to have it reviewed again"
+		} else {
+			said += " and is reviewed again after a pause"
+		}
 		e, err := k.Store.Get(ctx, w.Key())
 		if err != nil || e == nil {
 			return "", fmt.Errorf("%s: %s, and that could not be kept (%v)", w.Key(), said, err)