diff --git a/modules/gitea/index.ts b/modules/gitea/index.ts index 063ad645..d1e29d8d 100644 --- a/modules/gitea/index.ts +++ b/modules/gitea/index.ts @@ -589,7 +589,11 @@ if (gitea) { }; // **The forge's events first, the polls as the safety net** (novox/hq issue 729): while verified deliveries arrive the // polls slow to every five minutes and announce only what no event said (Pace); otherwise they keep 30 s. - await listenForForge(client); + // **Not awaited** (novox/hq issue 1726): the receiver's set-up asks the forge's admin API, and the runtime kills a bundle + // whose import has not ended in its 10 s handshake and never starts it again; a forge slow to answer while every bundle + // of the node starts left gitea_commit_status, gitea_merge_pull_request and gitea_events served nowhere. Until it is + // listening, Pace keeps the polls at 30 s, so nothing is missed meanwhile; listenForForge says its own failure. + void listenForForge(client); // Main takes no push and only the tools' account merges, in every repository, kept and not only when a token is // minted: at the start and every ten minutes after, so a repository made later gets it too (issue 948, ADR 0398 ยง2). // Only while the setting keep-main-rules is true (mainrules.ts); false, the default, leaves every repository's rule as set. diff --git a/modules/gitea/test/bundle-import.test.ts b/modules/gitea/test/bundle-import.test.ts index c971fe06..5fb550b9 100644 --- a/modules/gitea/test/bundle-import.test.ts +++ b/modules/gitea/test/bundle-import.test.ts @@ -109,3 +109,53 @@ test("a bundle whose read of the checker's owed is granted late writes the lates assert.match(got.statuses[0], /"state":"success".*pass at 4/); assert.match(err, /mesh-delivery-checker\.owed could not be bound/, "the refusal is said"); }); + +// **The bundle's import does not wait on the forge** (novox/hq issue 1726, 2026-10-24 12:37). The webhook receiver's set-up +// asks the forge's admin API for its system webhook; awaited at the top of index.ts, a forge slow to answer (busy while +// every bundle of the node starts) held the import past node-tools' 10 s handshake, the bundle was killed and never +// started again, and gitea_commit_status, gitea_merge_pull_request and gitea_events were served nowhere: the forge +// bridge's calls found no responders and no new pull request was announced. Here the forge stand-in takes every +// request and never answers: the import resolves at once all the same, with the bundle's tools registered. +test("importing the bundle resolves, its tools registered, while the forge never answers the webhook's set-up", async () => { + const index = pathToFileURL(join(here, "..", "dist", "index.js")).href; + const script = ` + const http = await import("node:http"); + const fs = await import("node:fs"); + const os = await import("node:os"); + const path = await import("node:path"); + const forge = http.createServer(() => {}); + await new Promise((r) => forge.listen(0, "127.0.0.1", r)); + const dir = fs.mkdtempSync(path.join(os.tmpdir(), "gitea-1726-")); + fs.writeFileSync(path.join(dir, "admin.password"), "pw"); + process.env.MESH_GITEA_URL = "http://127.0.0.1:" + forge.address().port; + process.env.MESH_GITEA_STATE_DIR = dir; + process.env.MESH_GITEA_ADMIN_PASSWORD_FILE = path.join(dir, "admin.password"); + process.env.MESH_GITEA_HOOK_PORT = "0"; + process.env.MESH_GITEA_HOOK_HOST = "127.0.0.1"; + const { useBroker } = await import("@novox/mesh-sdk/messaging"); + useBroker(() => ({ + subscribe: async () => () => {}, publish: async () => {}, request: async () => { throw new Error("no responders"); }, + handle: async () => () => {}, close: async () => {}, + })); + await import(${JSON.stringify(index)}); + const { collectTools } = await import("@novox/mesh-sdk/tools"); + console.log(JSON.stringify({ imported: true, tools: collectTools().flatMap((r) => r.tools.map((t) => t.name)) })); + process.exit(0);`; + const env = { ...process.env, MESH_GITEA_TOKEN: "x", MESH_GITEA_ADMIN_USER: "admin", MESH_GITEA_HOOK_URL: "http://127.0.0.1:1" }; + for (const k of ["MESH_SERVED_MODULE", "MESH_GITEA_ADMIN_PASSWORD", "MESH_GITEA_CONFIG_FILE"]) delete env[k]; + const child = spawn(process.execPath, ["--input-type=module", "-e", script], { cwd: join(here, ".."), env, stdio: ["ignore", "pipe", "pipe"] }); + let out = ""; + let err = ""; + child.stdout.on("data", (d) => (out += d)); + child.stderr.on("data", (d) => (err += d)); + const ended = new Promise((r) => child.on("exit", () => r())); + const timer = setTimeout(() => child.kill("SIGKILL"), 3000); + await ended; + clearTimeout(timer); + const line = out.split("\n").find((l) => l.startsWith("{")); + assert.ok(line, `the import did not resolve within 3 s while the forge did not answer; stdout: ${out.slice(0, 400)} stderr: ${err.slice(0, 600)}`); + const got = JSON.parse(line!) as { tools: string[] }; + for (const t of ["gitea_events", "gitea_commit_status", "gitea_merge_pull_request"]) { + assert.ok(got.tools.includes(t), `${t} is registered: ${got.tools}`); + } +});