Event names are local now, in the manifests and in the code
Every module named its events the way the old bus spelled a routing key — `module.<module>.<verb>`. Design 29 says a module names an event locally and the mesh works out where it lands, so all 37 were stale against a rule already decided. On the new bus that derives into a namespace belonging to a module called "module", so no cross-module subscription in the mesh matched anything: nothing failed, nothing reacted (novox/hq 04-ISSUES/127). 36 manifests converted, and 43 files of module code with them. The code mattered as much as the manifests: the runtime builds the subject from what `emit()` is handed, so a converted manifest with unconverted code would have had the permission and the subject disagree. Three things the new check found on the way: - `photos` emitted an event its manifest never declared, which the new bus refuses outright. Declared. - `showcase` waited for an event nothing emits, so its demo could never be triggered — only `showcase` may publish under its own name. It emits both halves now. - `distribution` declared an event named after a different module. It emits `image.pushed` under its own name. An event about a *role* belongs on the seat, where the name outlives whoever holds it, but the sdk has no way to publish on a seat yet, so that stays recorded rather than declared. The audit logger's "everything" pattern is `**` rather than the old bus's `#`.
This commit is contained in:
@@ -28,7 +28,7 @@ async function pollPackages(): Promise<void> {
|
||||
const known = latest.get(pkg.name);
|
||||
if (known !== pkg.version) {
|
||||
// A name we have not seen, or a name whose latest version moved — both are a publish.
|
||||
if (primed) await emit("module.verdaccio.package.published", { name: pkg.name, version: pkg.version });
|
||||
if (primed) await emit("package.published", { name: pkg.name, version: pkg.version });
|
||||
latest.set(pkg.name, pkg.version);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user