From 820840076f09754a0f3bdc4fa8b303975ab9354d Mon Sep 17 00:00:00 2001 From: jochen Date: Sat, 21 Nov 2026 15:37:46 +0100 Subject: [PATCH] nats: the whole test waits for the first fill pass, not a first view's answer (H-A-268) The keeper never marks a first view listing no module as answered (A-367), so the subtest waited for what cannot come and hid every later subtest. It waits for the first fill pass and takes it as the first. Builds: design 47 H H-A-268 --- modules/nats/cmd/nats-tools/keeper_integration_test.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/nats/cmd/nats-tools/keeper_integration_test.go b/modules/nats/cmd/nats-tools/keeper_integration_test.go index 5b070fd78..8f9ca6c45 100644 --- a/modules/nats/cmd/nats-tools/keeper_integration_test.go +++ b/modules/nats/cmd/nats-tools/keeper_integration_test.go @@ -316,7 +316,9 @@ func TestTheBusModuleRunsWhole(t *testing.T) { _ = Keep(kctx, deaf, func(context.Context, func(string, []byte) error) error { return errors.New("no consumer yet") }, nil, nil, t.Logf) close(done) }() - eventually(t, "the first view answered", func() bool { return !deaf.Status().FirstView.Answered.IsZero() }) + // A first view listing no module is none yet and never marked answered (A-367): the first fill pass is waited + // for instead, then taken as the first (design 47 H, H-A-268). + eventually(t, "the first fill pass", func() bool { return !deaf.Status().Pass.IsZero() }) first := deaf.Status().Pass eventually(t, "a fill pass while the consumer is bound again", func() bool { return deaf.Status().Pass.After(first) }) stopDeaf()