Pull the Node build seat's asks beside the tools, delivery first and at most the node's capacity (issue 1887 A3node, ADR 0525 §2-§6)

2026-10-23 15:39:30 +02:00
parent 6e823d1f9b
commit 8356d30e1b
7 changed files with 226 additions and 6 deletions
@@ -0,0 +1,72 @@
+package main
+
+import (
+	"context"
+
+	stdio "git.novox.be/novox/mesh-sdk/go"
+	"git.novox.be/novox/mesh-sdk/go/buildstep"
+	"git.novox.be/novox/mesh-sdk/go/delivery"
+)
+
+// **The module pulls its seat's asks** (novox/hq ADR 0525 §2-§6, ADR 0536 §4; issue 1887 A3node), as mesh-build-go
+// does: the seat node-build-node, delivery first, then check, then recheck, at most the node's build capacity at once
+// (its setting `capacity`); each ask runs with the step bodies its tools run, behind the same guard, and ends on the key
+// <node>.<ask id>. The tools stay as the hand path (ADR 0525 §8).
+
+// Seat is the node seat this module holds.
+const Seat = "node-build-node"
+
+func (m *Module) askSteps(steps []StepTool) buildstep.AskSteps {
+	byName := map[string]buildstep.StepFunc{}
+	for _, s := range steps {
+		run := s.Run
+		byName[s.Name] = func(ctx context.Context, args map[string]any) (any, error) {
+			defer m.holdArg(args)()
+			return run(ctx, args)
+		}
+	}
+	return buildstep.AskSteps{
+		Fetch: byName["build_node_fetch"], Build: byName["build_node_build"], Test: byName["build_node_test"],
+		Toolchain: func(ctx context.Context) (delivery.ToolchainUsed, error) {
+			installed, err := m.Probe(ctx)
+			if err != nil {
+				return delivery.ToolchainUsed{}, err
+			}
+			return delivery.ToolchainUsed{Version: installed, Recipe: m.recipe().Version()}, nil
+		},
+		Release: func(ws string) error { return m.spaces().Release(ws) },
+		Logf:    m.Say,
+	}
+}
+
+// Puller is the module's pull of its seat's asks, on source (the runtime's seat pull when nil).
+func (m *Module) Puller(steps []StepTool, source buildstep.AskSource) *buildstep.Puller {
+	if source == nil {
+		source = buildstep.SeatAsks{Language: delivery.AskNode}
+	}
+	capacity := m.Capacity
+	if capacity == nil {
+		capacity = buildstep.NodeCapacity(m.Settings, buildstep.DefaultCapacities, m.Node, m.Say)
+	}
+	ask := m.askSteps(steps)
+	var load func(string) ([]byte, error)
+	if m.ReadSteps.Get != nil {
+		load = func(key string) ([]byte, error) { return m.ReadSteps.Get(key) }
+	}
+	return &buildstep.Puller{Source: source, Language: delivery.AskNode, Node: m.Node, Put: m.Steps, Load: load,
+		Capacity: capacity, Logf: m.Say,
+		Run: func(ctx context.Context, a delivery.StepAsk) (any, error) {
+			if err := m.Prepare(ctx); err != nil {
+				return nil, err
+			}
+			if err := m.room(); err != nil {
+				return nil, err
+			}
+			return buildstep.RunAsk(ctx, ask, a)
+		}}
+}
+
+// SeatTools are the seat's verbs on this node (ADR 0525 §10).
+func (m *Module) SeatTools(p *buildstep.Puller) []stdio.Tool {
+	return buildstep.SeatTools(Seat, "Node", p)
+}