From 83accdbb4e178c05c1bff48de8cc34f160e81ad9 Mon Sep 17 00:00:00 2001 From: jochen Date: Thu, 19 Nov 2026 15:45:49 +0100 Subject: [PATCH] build modules: cite A-489c on the runs-counted kit tests and failurekit's refusal MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Builds: design 47 G ยง24; lead answer A-489c Claude-Session: https://claude.ai/code/session_01JG73KHUnBze48rdua8u2sy --- checks/failurekit/failurekit.go | 1 + modules/mesh-build-go/cmd/mesh-build-go/kit_test.go | 2 +- modules/mesh-build-image/cmd/mesh-build-image/kit_test.go | 2 +- modules/mesh-build-node/cmd/mesh-build-node/kit_test.go | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/checks/failurekit/failurekit.go b/checks/failurekit/failurekit.go index b188ef5fb..561138846 100644 --- a/checks/failurekit/failurekit.go +++ b/checks/failurekit/failurekit.go @@ -102,6 +102,7 @@ func Judge(root string) ([]Judged, error) { return nil, err } if !counts { + // A-489c refused = append(refused, fmt.Sprintf("it claims %s, and no test of it calls conformance.RunsCounted "+ "(mesh-delivery-sdk steprun/conformance): run the kit's case that its puller counts the runs that started, not the bus's deliveries (A-489a)", seat)) } diff --git a/modules/mesh-build-go/cmd/mesh-build-go/kit_test.go b/modules/mesh-build-go/cmd/mesh-build-go/kit_test.go index 8afd7d673..4cbf1de79 100644 --- a/modules/mesh-build-go/cmd/mesh-build-go/kit_test.go +++ b/modules/mesh-build-go/cmd/mesh-build-go/kit_test.go @@ -63,7 +63,7 @@ func TestTheStepsCanSayAStepsEnd(t *testing.T) { conformance.StepEnds(t, (&Module{Node: "kitnode"}).askSteps(nil)) } -// A-489a: the module's puller counts the runs its steps state says started, not the bus's deliveries (an ask given back before +// A-489c (A-489a): the module's puller counts the runs its steps state says started, not the bus's deliveries (an ask given back before // it ran is no run), so the poison rule never ends an ask that never ran. func TestThePullerCountsRunsThatStarted(t *testing.T) { conformance.RunsCounted(t, func(read func(string) (json.RawMessage, error)) *steprun.Puller { diff --git a/modules/mesh-build-image/cmd/mesh-build-image/kit_test.go b/modules/mesh-build-image/cmd/mesh-build-image/kit_test.go index 0dfd8ce8e..1dea213b0 100644 --- a/modules/mesh-build-image/cmd/mesh-build-image/kit_test.go +++ b/modules/mesh-build-image/cmd/mesh-build-image/kit_test.go @@ -52,7 +52,7 @@ func TestTheStepsCanSayAStepsEnd(t *testing.T) { conformance.StepEnds(t, (&Module{Node: "kitnode"}).askSteps(nil)) } -// A-489a: the module's puller counts the runs its steps state says started, not the bus's deliveries (an ask given back before +// A-489c (A-489a): the module's puller counts the runs its steps state says started, not the bus's deliveries (an ask given back before // it ran is no run), so the poison rule never ends an ask that never ran. func TestThePullerCountsRunsThatStarted(t *testing.T) { conformance.RunsCounted(t, func(read func(string) (json.RawMessage, error)) *steprun.Puller { diff --git a/modules/mesh-build-node/cmd/mesh-build-node/kit_test.go b/modules/mesh-build-node/cmd/mesh-build-node/kit_test.go index 2fbbcac74..a9dc94efb 100644 --- a/modules/mesh-build-node/cmd/mesh-build-node/kit_test.go +++ b/modules/mesh-build-node/cmd/mesh-build-node/kit_test.go @@ -57,7 +57,7 @@ func TestTheStepsCanSayAStepsEnd(t *testing.T) { conformance.StepEnds(t, (&Module{Node: "kitnode"}).askSteps(nil)) } -// A-489a: the module's puller counts the runs its steps state says started, not the bus's deliveries (an ask given back before +// A-489c (A-489a): the module's puller counts the runs its steps state says started, not the bus's deliveries (an ask given back before // it ran is no run), so the poison rule never ends an ask that never ran. func TestThePullerCountsRunsThatStarted(t *testing.T) { conformance.RunsCounted(t, func(read func(string) (json.RawMessage, error)) *steprun.Puller {