Name no node: the forge owner in claude-code's, mesh-config's, mesh-issues's, messenger's and records's test data becomes acme (issue 1838)
This commit is contained in:
@@ -9,7 +9,7 @@ import (
|
||||
// as `mesh-controller.status` named it when the link was refused, the others as `mesh-controller.conditions`
|
||||
// answered on 2026-10-11.
|
||||
var realConditionKeys = []string{
|
||||
"delivery.novox/mesh-controller_d2e9dc61590f.stalled", // a delivery's id carries its repository, owner/name
|
||||
"delivery.acme/mesh-controller_d2e9dc61590f.stalled", // a delivery's id carries its repository, owner/name
|
||||
"machine.node-c.telegram.telegram-token.secret-given",
|
||||
"module.openrazer.node-d.relogin-needed",
|
||||
"mesh.hand-acts.plans_go.healer-wanted", // a space in the id, made `_` by the controller
|
||||
@@ -42,7 +42,7 @@ func TestAConditionLinkRefusesWhatTheControllerNeverRaises(t *testing.T) {
|
||||
"machine..secret-given", // an empty token
|
||||
"machine.node-c.secret given", // a space the controller makes `_`
|
||||
"machine.node-c:1.secret-given", // a colon the controller makes `_`
|
||||
"delivery.novox/mesh-controller@d2e9dc61590f.stalled", // `@` too
|
||||
"delivery.acme/mesh-controller@d2e9dc61590f.stalled", // `@` too
|
||||
"machine.*.silent", // a wildcard on the bus
|
||||
"machine.>", // a wildcard on the bus
|
||||
"machine.node-a.silent\nmore", // a second line
|
||||
@@ -57,11 +57,11 @@ func TestAConditionLinkRefusesWhatTheControllerNeverRaises(t *testing.T) {
|
||||
// A delivery link takes every id mesh-delivery gives (novox/hq issue 475): the ids are real, as
|
||||
// `mesh-delivery.deliveries` answered on 2026-10-11.
|
||||
var realDeliveryIDs = []string{
|
||||
"novox/mesh-controller@0f853e93fa11",
|
||||
"novox/mesh-catalog@7714f164c33f",
|
||||
"novox/hq@34bdb1a34f5a",
|
||||
"novox/mesh-media-catalog@dd3f0abb3f78",
|
||||
"novox/mesh-tools@82aefe1988c2",
|
||||
"acme/mesh-controller@0f853e93fa11",
|
||||
"acme/mesh-catalog@7714f164c33f",
|
||||
"acme/hq@34bdb1a34f5a",
|
||||
"acme/mesh-media-catalog@dd3f0abb3f78",
|
||||
"acme/mesh-tools@82aefe1988c2",
|
||||
}
|
||||
|
||||
func TestADeliveryLinkTakesEveryIdMeshDeliveryGives(t *testing.T) {
|
||||
@@ -74,15 +74,15 @@ func TestADeliveryLinkTakesEveryIdMeshDeliveryGives(t *testing.T) {
|
||||
}
|
||||
for _, id := range []string{
|
||||
"",
|
||||
"mesh-controller@0f853e93fa11", // no owner
|
||||
"novox/mesh-controller", // no commit
|
||||
"novox/mesh-controller@0f853e93fa11aa", // more than twelve characters of the commit
|
||||
"Novox/Mesh-Controller@0f853e93fa11", // mesh-delivery lower-cases the repository
|
||||
"novox/mesh-controller@0F853E93FA11", // a commit is lower-case hex
|
||||
"novox/mesh-controller@main", // a branch, not a commit
|
||||
"novox/mesh/controller@0f853e93fa11", // a repository is owner/name, no deeper
|
||||
"novox/mesh-controller_d2e9dc61590f", // a condition key's form of it, not the id
|
||||
"novox/mesh-controller@0f853e93fa11\nmore", // a second line
|
||||
"mesh-controller@0f853e93fa11", // no owner
|
||||
"acme/mesh-controller", // no commit
|
||||
"acme/mesh-controller@0f853e93fa11aa", // more than twelve characters of the commit
|
||||
"Novox/Mesh-Controller@0f853e93fa11", // mesh-delivery lower-cases the repository
|
||||
"acme/mesh-controller@0F853E93FA11", // a commit is lower-case hex
|
||||
"acme/mesh-controller@main", // a branch, not a commit
|
||||
"acme/mesh/controller@0f853e93fa11", // a repository is owner/name, no deeper
|
||||
"acme/mesh-controller_d2e9dc61590f", // a condition key's form of it, not the id
|
||||
"acme/mesh-controller@0f853e93fa11\nmore", // a second line
|
||||
} {
|
||||
if _, err := checkTarget(LinkDelivery, id); err == nil {
|
||||
t.Errorf("%q was taken as a delivery's id", id)
|
||||
|
||||
@@ -52,7 +52,7 @@ func transition(t *testing.T, h *harness, number int, to, why, mergedAs string,
|
||||
// transitionOn is a delivery's transition said under an event's name.
|
||||
func transitionOn(t *testing.T, h *harness, event string, number int, to, why, mergedAs string, at time.Time) {
|
||||
t.Helper()
|
||||
raw, _ := json.Marshal(map[string]any{"repository": "novox/mesh-catalog", "number": number, "to": to, "why": why,
|
||||
raw, _ := json.Marshal(map[string]any{"repository": "acme/mesh-catalog", "number": number, "to": to, "why": why,
|
||||
"merged_as": mergedAs, "at": at})
|
||||
if err := h.OnTransition(stdio.Envelope{Key: event, Body: raw}); err != nil {
|
||||
t.Fatal(err)
|
||||
|
||||
@@ -38,7 +38,7 @@ func (c *fixClock) later(d time.Duration) time.Time { c.at = c.at.Add(d); return
|
||||
// delivery says one transition of a pull request as mesh-delivery says it, with what a fix's time is read by.
|
||||
func (c *fixClock) delivery(t *testing.T, number int, to, class string, opened, mergedAt *time.Time) {
|
||||
t.Helper()
|
||||
body := map[string]any{"repository": "novox/mesh-catalog", "number": number, "to": to, "at": c.at}
|
||||
body := map[string]any{"repository": "acme/mesh-catalog", "number": number, "to": to, "at": c.at}
|
||||
if mergedAt != nil {
|
||||
body["merged_as"] = "m" + strings.Repeat("a", 11)
|
||||
body["merged_at"] = *mergedAt
|
||||
|
||||
@@ -279,7 +279,7 @@ func writeEverything(t *testing.T, h *harness) []uint64 {
|
||||
if _, err := h.Set(SetAsk{Number: a, Severity: "major", Needs: "decision"}); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, err := h.Move(MoveAsk{Number: a, Status: StatusFixing, By: "fix@node-b", FixedBy: []string{"novox/mesh-catalog#1"}}); err != nil {
|
||||
if _, err := h.Move(MoveAsk{Number: a, Status: StatusFixing, By: "fix@node-b", FixedBy: []string{"acme/mesh-catalog#1"}}); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, err := h.Move(MoveAsk{Number: c, Status: StatusWontfix, Reason: "not ours"}); err != nil {
|
||||
|
||||
@@ -67,7 +67,7 @@ func TestTheFrontmatterOfRealReportsIsReadAsWritten(t *testing.T) {
|
||||
Number: 236, Status: StatusResolved, Opened: "2026-10-04",
|
||||
Title: "The catalogue check passes a manifest the host refuses",
|
||||
LocatedIn: []string{"mesh-controller cmd/mesh-controller (the merge gate)"},
|
||||
FixedBy: []string{"novox/mesh-controller PR #96 (bbd442c, the merge gate, ADR 0237)"},
|
||||
FixedBy: []string{"acme/mesh-controller PR #96 (bbd442c, the merge gate, ADR 0237)"},
|
||||
Replay: "R236",
|
||||
}},
|
||||
{"345-a-reminder-window-shows-transparent-and-empty", Report{
|
||||
|
||||
+1
-1
@@ -2,7 +2,7 @@
|
||||
status: resolved
|
||||
opened: 2026-10-04
|
||||
located-in: [mesh-controller cmd/mesh-controller (the merge gate)]
|
||||
fixed-by: novox/mesh-controller PR #96 (bbd442c, the merge gate, ADR 0237)
|
||||
fixed-by: acme/mesh-controller PR #96 (bbd442c, the merge gate, ADR 0237)
|
||||
replay: R236
|
||||
amended-design:
|
||||
---
|
||||
|
||||
@@ -487,7 +487,7 @@ func TestLinksAreTypedAddedOnceAndRemoved(t *testing.T) {
|
||||
{Kind: LinkDecision, Target: "0275"},
|
||||
{Kind: LinkDesign, Target: "03-DESIGN/01-to-be/53-the-issue-tracker.md"},
|
||||
{Kind: LinkCondition, Target: "mesh.hand-acts.backup.healer-wanted"},
|
||||
{Kind: LinkDelivery, Target: "novox/mesh-controller@0f853e93fa11"},
|
||||
{Kind: LinkDelivery, Target: "acme/mesh-controller@0f853e93fa11"},
|
||||
}
|
||||
for _, l := range good {
|
||||
l.Number = a
|
||||
|
||||
@@ -465,14 +465,14 @@ func TestAnIssueIsReadyOnlyWhenWhatItDependsOnIsDelivered(t *testing.T) {
|
||||
}
|
||||
return Delivery{State: "ready"}, nil
|
||||
}
|
||||
resolve(t, h, dep, "novox/mesh-catalog#9", "a commit abc123")
|
||||
resolve(t, h, dep, "acme/mesh-catalog#9", "a commit abc123")
|
||||
if err := h.OnMoved(stdio.Envelope{Body: json.RawMessage(`{"number":365,"to":"resolved"}`)}); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if asked != 1 || ready(h, w) {
|
||||
t.Fatalf("ready before its fix is delivered (asked %d)", asked)
|
||||
}
|
||||
tr := stdio.Envelope{Key: "mesh-delivery-gate.transition", Body: json.RawMessage(`{"repository":"novox/mesh-catalog","number":9,"to":"delivered"}`)}
|
||||
tr := stdio.Envelope{Key: "mesh-delivery-gate.transition", Body: json.RawMessage(`{"repository":"acme/mesh-catalog","number":9,"to":"delivered"}`)}
|
||||
for i := 0; i < 2; i++ {
|
||||
if err := h.OnTransition(tr); err != nil {
|
||||
t.Fatal(err)
|
||||
@@ -764,14 +764,14 @@ func TestReadyIsSaidOnceFollowsDuplicatesAndAskingFailsLoudly(t *testing.T) {
|
||||
_, _ = h.Link(LinkAsk{Number: w, Kind: LinkDependsOn, Target: keyOf(b)})
|
||||
h.Deliveries = func(string, string) (Delivery, error) { return Delivery{State: "published"}, nil }
|
||||
resolve(t, h, a, "Mesh-Catalog#9")
|
||||
resolve(t, h, b, "https://forge.example/novox/mesh-catalog/pulls/9")
|
||||
resolve(t, h, b, "https://forge.example/acme/mesh-catalog/pulls/9")
|
||||
if got := pullRequests(get(t, h, a)); !reflect.DeepEqual(got, []string{"mesh-catalog#9"}) {
|
||||
t.Fatalf("%v", got)
|
||||
}
|
||||
if got := pullRequests(get(t, h, b)); !reflect.DeepEqual(got, []string{"mesh-catalog#9"}) {
|
||||
t.Fatalf("%v", got)
|
||||
}
|
||||
tr := stdio.Envelope{Body: json.RawMessage(`{"repository":"novox/mesh-catalog","number":9,"to":"delivered"}`)}
|
||||
tr := stdio.Envelope{Body: json.RawMessage(`{"repository":"acme/mesh-catalog","number":9,"to":"delivered"}`)}
|
||||
if err := h.OnTransition(tr); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user