A closing is reviewed on its closing alone: the question holds the move, the note and the added links, never old text or linked clauses (issue 784, ADR 0630)

Claude-Session: https://claude.ai/code/session_01JG73KG7AfSdh6FP8VrBqCn
This commit is contained in:
2026-11-04 15:55:58 +01:00
parent d2f326dff4
commit a198a959fe
3 changed files with 63 additions and 12 deletions
@@ -429,10 +429,21 @@ func (k *KB) reviewOne(key Key) (string, error) {
return "", err
}
w := e.Working()
question := ReviewQuestion(w, linked)
var question string
if w.Pending != nil && w.Pending.Closing != nil {
// A closing is judged on its closing alone (ADR 0630 §2).
question = ClosingQuestion(w, linked)
// A closing is judged on its closing alone (ADR 0630 §2): never the old sections, and of the records it
// links only the ones the closing adds.
var added []*Record
for _, l := range w.Pending.Closing.Added {
for _, t := range linked {
if to, ok := l.To.Record(); ok && t.Key() == to {
added = append(added, t)
}
}
}
question = ClosingQuestion(w, e.Current.Status, added)
} else {
question = ReviewQuestion(w, linked)
}
var verdict string
var findings []string