Let nginx through only-office's lib directory, so it can serve the converted files the document service writes there instead of answering 403 (issue 1837)
mesh/check failed: unit: i3/cmd/i3-tools.TestTheMainFileAndEveryModulesContributionLoadTogether: manifest_test.go:247: expected the launcher, clipboar…
mesh/merge-gate head a22fdd015b09 merged into trunk 7842001c53f7 — pass: builds only-office → novox; no bus step; every machine composes with the change as…
mesh/repo-check head a22fdd015b09 merged into trunk 7842001c53f7 — pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-…
mesh/delivery delivered

This commit is contained in:
jochen
2026-10-22 14:32:06 +02:00
parent dcf6e86d02
commit a22fdd015b
2 changed files with 33 additions and 1 deletions
+32
View File
@@ -1,6 +1,7 @@
package office
import (
"encoding/json"
"os"
"strings"
"testing"
@@ -93,3 +94,34 @@ func TestSecureLinkSecretIsPinned(t *testing.T) {
t.Errorf("files/server.env does not set SECURE_LINK_SECRET=${secret:secure-link}:\n%s", env)
}
}
// 1837/AC3 (unit: manifest check)
// Given the catalogue, when only-office's manifest is read, then the lib directory (mounted at
// /var/lib/onlyoffice, where the document service writes the converted files nginx serves) lets
// other users pass through it (mode 0711): the image makes it the document service's own, and nginx
// runs as another user, so a mode of 0700 makes nginx answer 403 "Permission denied" on Editor.bin.
func TestLibDirectoryLetsNginxThrough(t *testing.T) {
raw, err := os.ReadFile("module.json")
if err != nil {
t.Fatalf("reading module.json: %v", err)
}
var m struct {
Resources []struct {
ID string `json:"id"`
Type string `json:"type"`
Mode string `json:"mode"`
} `json:"resources"`
}
if err := json.Unmarshal(raw, &m); err != nil {
t.Fatalf("parsing module.json: %v", err)
}
for _, r := range m.Resources {
if r.ID == "lib" && r.Type == "directory" {
if r.Mode != "0711" {
t.Errorf("lib directory mode = %q, want 0711 so nginx can reach the document service's cache", r.Mode)
}
return
}
}
t.Fatal("manifest declares no lib directory")
}
+1 -1
View File
@@ -176,7 +176,7 @@
{
"id": "lib",
"type": "directory",
"mode": "0700",
"mode": "0711",
"unknown": "program"
},
{