Require node-tools in the three build modules, so the delivery plan puts the tool runner they pull asks through before them on every node (issue 1911)
This commit is contained in:
@@ -239,3 +239,12 @@ func TestTheModuleContributesWriteAccessToThePackageRegistry(t *testing.T) {
|
||||
t.Errorf("npm-package-registry access = %v, want write", got)
|
||||
}
|
||||
}
|
||||
|
||||
// 1911: the module pulls its asks through node-tools' seat pull (mesh-tools, R4g), so it requires node-tools on its node
|
||||
// and the delivery plan puts node-tools first: a node's build module never pulls through a tool runner that cannot.
|
||||
func TestTheModuleRequiresNodeToolsItPullsThrough(t *testing.T) {
|
||||
m := readManifest(t)
|
||||
if !slices.Contains(m.Requires, "node-tools") {
|
||||
t.Errorf("requires %v lack node-tools", m.Requires)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -50,7 +50,8 @@
|
||||
"forge-account",
|
||||
"npm-package-registry",
|
||||
"node-toolchain",
|
||||
"artifact-store"
|
||||
"artifact-store",
|
||||
"node-tools"
|
||||
],
|
||||
"contributes": {
|
||||
"npm-package-registry": {
|
||||
|
||||
Reference in New Issue
Block a user