Build modules: steps end by compare-and-set; pin the sdk head with the review's fixes (issue 1890)

This commit is contained in:
2026-10-26 13:44:00 +01:00
parent 5fe5f26e7e
commit ac2c56f2a9
15 changed files with 18 additions and 18 deletions
@@ -80,5 +80,5 @@ const StepEndTool = "build_node_step_end"
// stepScan is the module's steps state as buildstep reads it.
func (m *Module) stepScan() buildstep.Scan {
return buildstep.Scan{Keys: m.ReadSteps.Keys, Get: m.ReadSteps.Get}
return buildstep.ScanOf(stdio.State(delivery.StepsState))
}
@@ -76,7 +76,7 @@ func main() {
m.Held = puller
if m.Node != "" {
// A step a previous process left running is ended (issue 1890); this process's own steps start after booted.
go buildstep.EndStaleAtStart(ctx, m.stepScan(), m.Steps, m.Node, booted, logf)
go buildstep.EndStaleAtStart(ctx, m.stepScan(), m.Node, booted, logf)
}
if m.Node != "" {
// The seat's asks, pulled once Serve has the runtime's channel; a pull before it is said and tried again.
@@ -41,7 +41,7 @@ func (m *Module) Tools(steps []StepTool) []stdio.Tool {
tools = append(tools, t)
}
tools = append(tools, m.ReadTools()...)
tools = append(tools, buildstep.StepEndTool(StepEndTool, m.Node, m.stepScan(), m.Steps, m.Held))
tools = append(tools, buildstep.StepEndTool(StepEndTool, m.Node, m.stepScan(), m.Held))
tools = append(tools, m.releaseTool())
return append(tools,
stdio.Tool{Name: StatusTool,