mesh-knowledge: give a never-reviewed notice its resolved line when raised, and test a refused clear and local time in a set zone (review of #219)

The operator's channel edits a cleared message with the resolved line it was raised with, so one sent only with the clear was never shown.
2026-10-11 19:41:45 +02:00
parent d45761678a
commit c394ecd9fd
6 changed files with 67 additions and 10 deletions
@@ -335,7 +335,9 @@ func (k *KB) tellUnreviewed(e *Entry) {
 		w.Key(), w.Judging.Tries, w.Judging.Reason)
 	explanation := "No review that could not be had counts as an approval. Its author proposes it again to have it reviewed again; " +
 		"until then the knowledge base's health names it. The knowledge base's get and history show it."
-	if err := k.Notify(key, summary, "A proposal was never reviewed: "+w.Key().String(), explanation); err != nil {
+	// The channel edits a cleared message with the resolved line given here, not the one sent with the clear.
+	resolved := w.Key().String() + " no longer waits for its review"
+	if err := k.Notify(key, summary, "A proposal was never reviewed: "+w.Key().String(), explanation, resolved); err != nil {
 		k.logf("[mesh-knowledge] the operator could not be told that %s was never reviewed: %v; the module's health still names it", w.Key(), err)
 	}
 }