From d221c633799ad0b62ab7fb9e43fdbe61635e2664 Mon Sep 17 00:00:00 2001 From: jochen Date: Mon, 2 Nov 2026 20:35:06 +0100 Subject: [PATCH] The composer test skips aloud when no node-engine is beside, since the running checker places none for the catalogue until this release is delivered It still fails when the node-engine is beside without its composer command, or when nothing is beside at all. Claude-Session: https://claude.ai/code/session_01NcbgfJ9Gum47zkFKWRaovL --- .../cmd/mesh-build-go/compose_integration_test.go | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/modules/mesh-build-go/cmd/mesh-build-go/compose_integration_test.go b/modules/mesh-build-go/cmd/mesh-build-go/compose_integration_test.go index ec5be35d..bf249d33 100644 --- a/modules/mesh-build-go/cmd/mesh-build-go/compose_integration_test.go +++ b/modules/mesh-build-go/cmd/mesh-build-go/compose_integration_test.go @@ -26,8 +26,10 @@ import ( // nodeEngineTree is the node-engine's repository as the checker places it beside this check (MESH_CHECK_BESIDE, the // repository mesh-host), and sdkBeside mesh-sdk's Go module there when it is placed too (a group that changes it). The test -// builds the node-engine's real composer command from that tree; it does not stand one in. Without the repository beside it -// fails: a composer test that could not build its composer proves nothing. +// builds the node-engine's real composer command from that tree; it does not stand one in. With no beside directory it +// fails, and with the node-engine beside but no composer command in it it fails: a composer test that could not build its +// composer proves nothing. With a beside directory that holds no node-engine at all it skips aloud (NOT JUDGED), since a +// checker from before this release places none for the catalogue. func nodeEngineTree(t *testing.T) (tree, sdk string) { t.Helper() beside := os.Getenv("MESH_CHECK_BESIDE") @@ -35,6 +37,11 @@ func nodeEngineTree(t *testing.T) (tree, sdk string) { t.Fatal("NOT CHECKED: MESH_CHECK_BESIDE is not set, so the node-engine's repository (mesh-host) is not beside this check") } tree = filepath.Join(beside, "mesh-host") + if !dirExists(tree) { + // A checker from before novox/hq ADR 0593 places only mesh-sdk beside a catalogue check, so the node-engine's + // repository is absent, not wrong: said aloud, since nothing here could build a composer to judge. + t.Skipf("NOT JUDGED: the node-engine's repository (mesh-host) is not beside this check in MESH_CHECK_BESIDE=%s; the running checker places none for the catalogue, so the composer is judged only once it does", beside) + } if _, err := os.Stat(filepath.Join(tree, "cmd", "mesh-compose")); err != nil { t.Fatalf("NOT CHECKED: the node-engine's composer command is not beside this check in MESH_CHECK_BESIDE=%s: %v", beside, err) }