mesh-issues: call an issue its worker left abandoned, not a stale claim (hq ADR 0294)
mesh/merge-gate pass: builds mesh-issues → novox; no bus step; every machine composes with the change as it did without (4 of 4 compose)
mesh/repo-check pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)
mesh/delivery delivered
mesh/merge-gate pass: builds mesh-issues → novox; no bus step; every machine composes with the change as it did without (4 of 4 compose)
mesh/repo-check pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)
mesh/delivery delivered
The glossary keeps claim for a module's on a seat.
This commit is contained in:
@@ -348,9 +348,9 @@ type Moved struct {
|
||||
Since *time.Time `json:"since,omitempty"`
|
||||
// TookOverFrom is the worker a take-over took the issue over from.
|
||||
TookOverFrom string `json:"took-over-from,omitempty"`
|
||||
// StaleClaim says the worker taken over from had a stale claim: nothing done on it past worker-stale-after and
|
||||
// Abandoned says the worker taken over from had abandoned it: nothing done on it past worker-stale-after and
|
||||
// no pull request open, so no reason was needed (novox/hq issue 483).
|
||||
StaleClaim bool `json:"stale-claim,omitempty"`
|
||||
Abandoned bool `json:"abandoned,omitempty"`
|
||||
// Released is the worker whose work on it the move ended.
|
||||
Released string `json:"released,omitempty"`
|
||||
Said string `json:"said"`
|
||||
@@ -521,9 +521,9 @@ func (t *Tracker) move(by string, a MoveAsk) (*Moved, error) {
|
||||
if takeOver != "" {
|
||||
body["take-over"] = takeOver
|
||||
}
|
||||
if work.staleClaim {
|
||||
out.StaleClaim, body["stale-claim"] = true, true
|
||||
out.Said += fmt.Sprintf(" Taken over from %s, whose claim was a stale claim (nothing done on it for %s and no "+
|
||||
if work.abandoned {
|
||||
out.Abandoned, body["abandoned"] = true, true
|
||||
out.Said += fmt.Sprintf(" Taken over from %s, who had abandoned it (nothing done on it for %s and no "+
|
||||
"pull request open); noted on the issue.", work.from, staleAfter)
|
||||
} else {
|
||||
out.Said += fmt.Sprintf(" Taken over from %s; noted on the issue.", work.from)
|
||||
@@ -722,7 +722,7 @@ type ListAsk struct {
|
||||
Needs string
|
||||
// Ready, when set, keeps only the issues ready (true) or not ready (false).
|
||||
Ready *bool
|
||||
// Flag keeps only the issues delivered and not resolved, or the stale claims (novox/hq issue 483).
|
||||
// Flag keeps only the issues delivered and not resolved, or the abandoned ones (novox/hq issue 483).
|
||||
Flag string
|
||||
}
|
||||
|
||||
@@ -744,10 +744,10 @@ type Row struct {
|
||||
Worker string `json:"worker,omitempty"`
|
||||
Since *time.Time `json:"since,omitempty"`
|
||||
Stale bool `json:"stale,omitempty"`
|
||||
// DeliveredNotResolved says it is in fixing with every fix it names delivered; StaleClaim that its worker
|
||||
// DeliveredNotResolved says it is in fixing with every fix it names delivered; Abandoned that its worker
|
||||
// did nothing on it for worker-stale-after and no pull request of it is open (novox/hq issue 483).
|
||||
DeliveredNotResolved bool `json:"delivered-not-resolved,omitempty"`
|
||||
StaleClaim bool `json:"stale-claim,omitempty"`
|
||||
Abandoned bool `json:"abandoned,omitempty"`
|
||||
}
|
||||
|
||||
// Listed is the answer to a list.
|
||||
@@ -842,7 +842,7 @@ func (t *Tracker) List(a ListAsk) (*Listed, error) {
|
||||
row.Worker, row.Since, row.Stale = c.By, &since, c.stale(now, staleAfter)
|
||||
}
|
||||
row.DeliveredNotResolved = deliveredNotResolved(is)
|
||||
row.StaleClaim = staleClaim(is, now, staleAfter)
|
||||
row.Abandoned = abandoned(is, now, staleAfter)
|
||||
out.Rows = append(out.Rows, row)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user