From dd8305d97d47a98192ca158827b1d3fe04a40020 Mon Sep 17 00:00:00 2001 From: jochen Date: Mon, 19 Oct 2026 11:10:36 +0200 Subject: [PATCH] mesh-mail: the refused-sign-in acceptance test's wait excluded queued too, so it returned done on the very first look before the sender ever claimed anything (issue 1198) --- .../mesh-mail/cmd/mesh-mail/acceptance_integration_test.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/modules/mesh-mail/cmd/mesh-mail/acceptance_integration_test.go b/modules/mesh-mail/cmd/mesh-mail/acceptance_integration_test.go index 11523fad..33ae896c 100644 --- a/modules/mesh-mail/cmd/mesh-mail/acceptance_integration_test.go +++ b/modules/mesh-mail/cmd/mesh-mail/acceptance_integration_test.go @@ -277,7 +277,12 @@ func TestMailSenderAcceptanceARefusedSignInFailsAfterItsAttemptsAndNothingIsRece if err != nil || !ok || kept.Decided == nil { return false, "not yet decided" } - return kept.Decided.Outcome != "retrying" && kept.Decided.Outcome != "sending", kept.Decided.Outcome + // "queued" is the send's own starting state (queueAnApprovedSend's own write, before the sender + // ever claims it): without excluding it here too, this check reads done on the very first look, + // long before the sender connects or claims anything at all (novox/hq review: build-1792400882114092431, + // 1198/AC4). + o := kept.Decided.Outcome + return o != "queued" && o != "retrying" && o != "sending", o }) cancel() <-done