From e3246fa11e8d83ed37819a2c45a5649115120906 Mon Sep 17 00:00:00 2001 From: jochen Date: Wed, 30 Sep 2026 22:33:19 +0200 Subject: [PATCH] A provider declares what it serves: mail's domain, the identity provider's issuer (issue 173) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Consumers read `${bound:smtp:domain}` and `${bound:oidc-client:issuer}`, and both keys reached them only because a module's settings were laid over everything it served. Issue 173 stops that: a setting overrides a key a served fact declares and adds none. So the two providers declare the keys their consumers read, as the operator's value (`${setting:…}`, ADR 0155), and the setting that already carries each fills it. Nothing a consumer reads changes. Merges first: under the controller that still merges settings over served facts this is the same value, and the controller that stops merging (mesh-controller, feat/the-mesh-places-its-own-files) needs these declared before it rolls out. --- modules/keycloak/module.json | 3 ++- modules/mailu/module.json | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/keycloak/module.json b/modules/keycloak/module.json index 1afc95e..083fd5b 100644 --- a/modules/keycloak/module.json +++ b/modules/keycloak/module.json @@ -51,7 +51,8 @@ "oidc-client": { "authorization-path": "/protocol/openid-connect/auth", "token-path": "/protocol/openid-connect/token", - "userinfo-path": "/protocol/openid-connect/userinfo" + "userinfo-path": "/protocol/openid-connect/userinfo", + "issuer": "${setting:issuer}" } }, "receives": { diff --git a/modules/mailu/module.json b/modules/mailu/module.json index 98447f6..df7943c 100644 --- a/modules/mailu/module.json +++ b/modules/mailu/module.json @@ -552,7 +552,8 @@ ], "serves": { "smtp": { - "port": 587 + "port": 587, + "domain": "${setting:domain}" } }, "receives": {