From e712cd227f3707ff37054700b5496fcd2a0892f7 Mon Sep 17 00:00:00 2001 From: jochen Date: Mon, 9 Nov 2026 23:44:08 +0100 Subject: [PATCH] =?UTF-8?q?C5:=20the=20integration=20row=20reads=20the=20d?= =?UTF-8?q?ropped=20step=20as=20dropped=20(ADR=200664=20=C2=A74,=20issue?= =?UTF-8?q?=201748=20review=201)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Claude-Session: https://claude.ai/code/session_01JG73KEq4zoDfM9WtYpcQgZ --- modules/mesh-build-go/buildstep/pull_integration_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/mesh-build-go/buildstep/pull_integration_test.go b/modules/mesh-build-go/buildstep/pull_integration_test.go index 38a5cc836..63bfc2df2 100644 --- a/modules/mesh-build-go/buildstep/pull_integration_test.go +++ b/modules/mesh-build-go/buildstep/pull_integration_test.go @@ -144,7 +144,7 @@ func TestPullRedeliversAKilledPullersAsk(t *testing.T) { // ADR 0664 §1, §5 (issue 1748) on the real server: a run that ends on a transport fault is written again and the bus gives the // ask again after the delay, not before, as the second run (its delivery count one higher), and that run's end is the ask's; -// a step that runs when its ask is dropped ends refused, naming who dropped it, and the ask is not given again. +// a step that runs when its ask is dropped ends dropped, naming who dropped it, and the ask is not given again. func TestAnAskThatMetTheNetworkIsGivenAgainAndADroppedOneIsEnded(t *testing.T) { js := askBus(t, 30*time.Second) a, doomed := testAsk(sdkstep.AskDelivery), testAsk(sdkstep.AskDelivery) @@ -189,7 +189,7 @@ func TestAnAskThatMetTheNetworkIsGivenAgainAndADroppedOneIsEnded(t *testing.T) { t.Fatal(err) } dkey, _ := sdkstep.AskStepKey("ace", doomed.ID) - waitFor(t, "the dropped step refused", func() bool { s, ok := st.get(dkey); return ok && s.State == sdkstep.StepRefused }) + waitFor(t, "the dropped step dropped", func() bool { s, ok := st.get(dkey); return ok && s.State == sdkstep.StepDropped }) if s, _ := st.get(dkey); !contains(s.Reason, "dropped by mesh-delivery-builder: superseded") { t.Errorf("the dropped step says %q", s.Reason) }