novox/mesh-catalog
6
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

The derived-value record is ADR 0202 (was 0201)

Browse Source
This commit is contained in:
jschoubben
2026-10-04 04:33:58 +02:00
parent 27315d35cf
commit ed10d96048
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/minio/client.ts
+1 -1
View File
@@ -305,7 +305,7 @@ export class MinioClient {
// **Neither the access key nor the bucket is derived here any more.** `accessKeyFor` minted an id // **Neither the access key nor the bucket is derived here any more.** `accessKeyFor` minted an id
// of its own until the mesh took that over (ADR 0048: the login is the mesh's, handed to both // of its own until the mesh took that over (ADR 0048: the login is the mesh's, handed to both
// ends), and `bucketFor` derived the bucket until the mesh took that over too (ADR 0201: the rule // ends), and `bucketFor` derived the bucket until the mesh took that over too (ADR 0202: the rule
// is a line of this module's manifest, filled per consumer and delivered to both ends). Both // is a line of this module's manifest, filled per consumer and delivered to both ends). Both
// survived with no callers, which is the state a rule comes back from; they are gone. // survived with no callers, which is the state a rule comes back from; they are gone.
modules/minio/provisioner/index.ts
+2 -2
View File
@@ -12,7 +12,7 @@
// creates the service account under exactly that access key with exactly that secret — a credential // creates the service account under exactly that access key with exactly that secret — a credential
// the provisioner invented is one the consumer could never present. // the provisioner invented is one the consumer could never present.
// //
// **The bucket name is the mesh's too (ADR 0201).** It used to be computed here, from the login, // **The bucket name is the mesh's too (ADR 0202).** It used to be computed here, from the login,
// and every consumer transcribed the same rule into its own definition by hand — two copies of // and every consumer transcribed the same rule into its own definition by hand — two copies of
// one rule with nothing comparing them, and one of three was wrong for months. Now the rule is a // one rule with nothing comparing them, and one of three was wrong for months. Now the rule is a
// line of this module's manifest (`serves.s3-bucket.bucket: ${consumer:as:dns}`), the mesh fills // line of this module's manifest (`serves.s3-bucket.bucket: ${consumer:as:dns}`), the mesh fills
@@ -79,7 +79,7 @@ function bucketNamed(derived: Readonly<Record<string, unknown>>): string {
if (typeof bucket !== "string" || bucket === "") { if (typeof bucket !== "string" || bucket === "") {
throw new Error( throw new Error(
"the mesh did not say which bucket this consumer gets: minio's manifest must serve " + "the mesh did not say which bucket this consumer gets: minio's manifest must serve " +
"`bucket` under s3-bucket (novox/hq ADR 0201)", "`bucket` under s3-bucket (novox/hq ADR 0202)",
); );
} }
return bucket; return bucket;