From f37f93e812dfd8fd55280bf9aac22f3787538ec7 Mon Sep 17 00:00:00 2001 From: jochen Date: Wed, 28 Oct 2026 21:00:09 +0100 Subject: [PATCH] Drop the unreachable 'before its check ends' caveat (issue 1733) --- .../mesh-delivery-gate/cmd/mesh-delivery-gate/approval.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/mesh-delivery-gate/cmd/mesh-delivery-gate/approval.go b/modules/mesh-delivery-gate/cmd/mesh-delivery-gate/approval.go index 1e08b31c..2a7ba773 100644 --- a/modules/mesh-delivery-gate/cmd/mesh-delivery-gate/approval.go +++ b/modules/mesh-delivery-gate/cmd/mesh-delivery-gate/approval.go @@ -157,8 +157,8 @@ func checkClause(c checkSaid, sep string) string { return ": " + c.Words } -// approveCaveat is what an Approve does beyond the merge while the check has not passed: it merges before the check ends, -// or although it failed (the check gates no merge, check-gates-merge false). Empty once it passed. +// approveCaveat is what an Approve does beyond the merge while the check has not passed: it merges although it failed (the check gates +// no merge, check-gates-merge false). Empty once it passed; an ask is made only with a verdict. func approveCaveat(c checkSaid) string { switch c.Key { case checkSaidPass: @@ -166,7 +166,7 @@ func approveCaveat(c checkSaid) string { case checkSaidFail: return " although its check failed" } - return " now, before its check ends" + return "" } // composeMergeAsk is the ask for a delivery, or for a group's members together.