From f5ce9808089b9ada05f7a73dd54b97ab07c74e74 Mon Sep 17 00:00:00 2001 From: jochen Date: Wed, 11 Nov 2026 22:45:02 +0100 Subject: [PATCH] =?UTF-8?q?GATE=20(A-42,=20=C2=A7592):=20the=20gate's=20ap?= =?UTF-8?q?proval-carried-open=20has=20scope=20delivery?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit FindingScope is delivery, the scope the mesh already uses for the delivery's findings; the test names the literal (it failed with gate). Builds: design 47 G §592, A-42 Claude-Session: https://claude.ai/code/session_01NcbgfGKaxw984XyAPfLm4h --- modules/mesh-delivery-gate/cmd/mesh-delivery-gate/findings.go | 4 ++-- .../cmd/mesh-delivery-gate/findings_test.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/mesh-delivery-gate/cmd/mesh-delivery-gate/findings.go b/modules/mesh-delivery-gate/cmd/mesh-delivery-gate/findings.go index 2594b5244..da2826bbc 100644 --- a/modules/mesh-delivery-gate/cmd/mesh-delivery-gate/findings.go +++ b/modules/mesh-delivery-gate/cmd/mesh-delivery-gate/findings.go @@ -20,9 +20,9 @@ import ( // Module is the gate's module name, the observer of its findings. const Module = "mesh-delivery-gate" -// The scope and the kind of the finding a carried approval nobody uses is (design 47 §592). +// The scope and the kind of the finding a carried approval nobody uses is (design 47 §592, A-42: the scope the mesh already uses for the delivery's findings). const ( - FindingScope = "gate" + FindingScope = "delivery" ApprovalCarriedOpen = "approval-carried-open" ) diff --git a/modules/mesh-delivery-gate/cmd/mesh-delivery-gate/findings_test.go b/modules/mesh-delivery-gate/cmd/mesh-delivery-gate/findings_test.go index 0e1fbdba2..959b0f9b0 100644 --- a/modules/mesh-delivery-gate/cmd/mesh-delivery-gate/findings_test.go +++ b/modules/mesh-delivery-gate/cmd/mesh-delivery-gate/findings_test.go @@ -93,7 +93,7 @@ func TestTheGatesApprovalCarriedOpenIsWrittenThroughItsHeldWriterAndClearedByThe t.Fatalf("held %+v", held) } for _, f := range held { - if f.Kind != ApprovalCarriedOpen || f.Scope != FindingScope || f.Observer != Module || !strings.Contains(f.Summary, head[:12]) { + if f.Kind != ApprovalCarriedOpen || f.Scope != "delivery" || f.Observer != Module || !strings.Contains(f.Summary, head[:12]) { t.Fatalf("finding %+v", f) } }