Review a long record within a bound sized to it, and let a proposal waiting on its author leave the knowledge base healthy (hq issue 508)

A judgement over one bus call's 30 seconds is collected by its ticket from
claude-code, so an eleven-clause record can be reviewed; a proposal out of
review tries is told to the operator, not raised as the module's fault, so
it no longer holds the module's own rollouts.

modules/claude-code/cmd/claude-code/judge_test.go

@@ -166,3 +166,102 @@ func TestTheToolTakesOnlyItsArguments(t *testing.T) {
 		t.Fatalf("%s", raw)
 	}
 }
+
+// A long question may ask a longer bound than one bus call allows (novox/hq issue 508): the call answers a ticket
+// when the judgement is not done within the call's wait, the judgement runs on to its own bound, and
+// claude_code_judged collects its answer.
+func TestALongJudgementIsCollectedByItsTicket(t *testing.T) {
+	var deadline time.Time
+	j := testJudge(true, true, func(ctx context.Context, _ []string, _ []byte) ([]byte, error) {
+		deadline, _ = ctx.Deadline()
+		select {
+		case <-time.After(400 * time.Millisecond):
+			return []byte(`{"structured_output":{"verdict":"none"}}`), nil
+		case <-ctx.Done():
+			return nil, ctx.Err()
+		}
+	})
+	j.Wait = 50 * time.Millisecond
+	start := time.Now()
+	out, err := j.Judge(JudgeAsk{Question: "a long record", Schema: verdictSchema, Within: 90 * time.Second})
+	if err != nil {
+		t.Fatal(err)
+	}
+	if !out.Pending || out.Ticket == "" || len(out.Answer) != 0 || out.Node != "control" {
+		t.Fatalf("not a ticket: %+v", out)
+	}
+	var got *Judged
+	for i := 0; i < 100; i++ {
+		got, err = j.Collect(out.Ticket)
+		if err != nil {
+			t.Fatal(err)
+		}
+		if !got.Pending {
+			break
+		}
+	}
+	if got.Pending || string(got.Answer) != `{"verdict":"none"}` || got.Ticket != out.Ticket {
+		t.Fatalf("%+v", got)
+	}
+	// Read once the judgement is collected: its end is what orders the agent's write before this read.
+	if left := deadline.Sub(start); left < 80*time.Second || left > 91*time.Second {
+		t.Fatalf("the judgement's bound is %s, not the 90s asked", left)
+	}
+	if _, err := j.Collect(out.Ticket); err == nil || !strings.Contains(err.Error(), "no judgement") {
+		t.Fatalf("a ticket collected twice: %v", err)
+	}
+}
+
+// A long judgement that fails says why when it is collected, and its bound is never past MostJudgeBound.
+func TestALongJudgementIsBoundedAndSaysWhyItFailed(t *testing.T) {
+	j := testJudge(true, true, func(ctx context.Context, _ []string, _ []byte) ([]byte, error) {
+		<-ctx.Done()
+		return nil, ctx.Err()
+	})
+	if _, err := j.Judge(JudgeAsk{Question: "q", Schema: verdictSchema, Within: MostJudgeBound + time.Second}); err == nil ||
+		!strings.Contains(err.Error(), "at most") {
+		t.Fatalf("a bound past the most taken: %v", err)
+	}
+	j.Wait = 20 * time.Millisecond
+	j.Bound = 30 * time.Millisecond // the test's stand-in for JudgeBound: within is past it, so a ticket
+	out, err := j.Judge(JudgeAsk{Question: "q", Schema: verdictSchema, Within: 200 * time.Millisecond})
+	if err != nil || !out.Pending {
+		t.Fatalf("%+v %v", out, err)
+	}
+	for i := 0; i < 100; i++ {
+		got, err := j.Collect(out.Ticket)
+		if err != nil {
+			if !strings.Contains(err.Error(), "did not answer within") {
+				t.Fatalf("%v", err)
+			}
+			return
+		}
+		if !got.Pending {
+			t.Fatalf("answered: %+v", got)
+		}
+	}
+	t.Fatal("never ended")
+}
+
+// The tools take within and ticket, and nothing else.
+func TestTheToolsTakeWithinAndTicket(t *testing.T) {
+	j := testJudge(true, true, func(context.Context, []string, []byte) ([]byte, error) {
+		return []byte(`{"structured_output":{"verdict":"none"}}`), nil
+	})
+	out, err := judgeTool(j).Run(map[string]any{"question": "q", "schema": verdictSchema, "within": float64(60)})
+	if err != nil {
+		t.Fatal(err)
+	}
+	if got := out.(*Judged); got.Pending || string(got.Answer) != `{"verdict":"none"}` {
+		t.Fatalf("a quick long judgement is answered in its call: %+v", got)
+	}
+	if _, err := judgeTool(j).Run(map[string]any{"question": "q", "schema": verdictSchema, "within": "long"}); err == nil {
+		t.Fatal("within as text was taken")
+	}
+	if _, err := judgedTool(j).Run(map[string]any{"ticket": "nope"}); err == nil || !strings.Contains(err.Error(), "no judgement") {
+		t.Fatalf("%v", err)
+	}
+	if _, err := judgedTool(j).Run(map[string]any{"ticket": "x", "by": "y"}); err == nil {
+		t.Fatal("an unknown argument was taken")
+	}
+}