mounts: list reads the root mount's unit (issue 374) #194

Merged
mesh-admin merged 1 commits from fix/374-mounts-list-reads-the-root-mounts-unit into main 2026-10-11 00:13:59 +00:00
Contributor

Fixes novox/hq issue 374 (node-mounts.list cannot read the units' properties: systemctl refuses the root mount's unit name).

What was wrong

List passed every mount and automount unit the service manager listed to systemctl show -p ... --no-pager <names>. The root mount's unit is -.mount, and systemctl reads an argument that starts with a dash as an option, so it refused the whole call. Every mount then came back without its unit state, not only the root's.

Captured on the desktop on 2026-10-11 02:00 through node-mounts.list:

"notes": [
  "the units' properties were not read: systemctl: exit status 1: systemctl: invalid option -- '.'\nHint: to specify units starting with a dash, use \"--\":\n      systemctl [OPTIONS…] COMMAND -- -.mount …"
]

The same answer said /mnt/recalbox ... mounted; ... no automount, although mnt-recalbox.automount is active (waiting) per node-service-manager.units: an autofs placeholder was taken as the mount, because the automount unit was never read.

The unit names come from the desktop's service manager (node-service-manager.units with pattern *mount), which lists -.mount first. The module's escaping is right (EscapePath("/") gives -, as systemd-escape --path does); only the separator was missing.

What changes

  • List puts -- before the unit names.
  • The test fake now refuses a dash-led argument before -- the way systemctl does, with systemctl's own message, so it no longer agrees with the mistake. The existing TestList fixture already listed -.mount and passed only because the fake accepted it.
  • New TestListReadsTheRootMountsUnit, built from the desktop's real unit names.

Other systemctl calls are unchanged: they name only the module's own units, and CheckMountpoint refuses /, so none of those names starts with a dash.

What I checked

  • Against unfixed code, TestListReadsTheRootMountsUnit failed with the desktop's note verbatim, and TestList failed (units missing, then a nil dereference in its own assertion).
  • With the fix: go test ./... and go vet ./... in modules/mounts pass; checks/words passes (none in 39400 strings).

What I did not verify

  • I did not run the whole merge-check.sh locally; the required checks run it.
  • I did not see the fixed module on the desktop. After delivery, node-mounts.list on the desktop should answer no note and each mount with its unit state, and /mnt/recalbox with its automount.
  • The systemctl show output in the new test is written by hand from the listed units' states, not captured; only the unit names and the error are captured.
Fixes novox/hq issue 374 (node-mounts.list cannot read the units' properties: systemctl refuses the root mount's unit name). ## What was wrong `List` passed every mount and automount unit the service manager listed to `systemctl show -p ... --no-pager <names>`. The root mount's unit is `-.mount`, and systemctl reads an argument that starts with a dash as an option, so it refused the whole call. Every mount then came back without its unit state, not only the root's. Captured on the desktop on 2026-10-11 02:00 through `node-mounts.list`: ``` "notes": [ "the units' properties were not read: systemctl: exit status 1: systemctl: invalid option -- '.'\nHint: to specify units starting with a dash, use \"--\":\n systemctl [OPTIONS…] COMMAND -- -.mount …" ] ``` The same answer said `/mnt/recalbox ... mounted; ... no automount`, although `mnt-recalbox.automount` is active (waiting) per `node-service-manager.units`: an autofs placeholder was taken as the mount, because the automount unit was never read. The unit names come from the desktop's service manager (`node-service-manager.units` with pattern `*mount`), which lists `-.mount` first. The module's escaping is right (`EscapePath("/")` gives `-`, as `systemd-escape --path` does); only the separator was missing. ## What changes - `List` puts `--` before the unit names. - The test fake now refuses a dash-led argument before `--` the way systemctl does, with systemctl's own message, so it no longer agrees with the mistake. The existing `TestList` fixture already listed `-.mount` and passed only because the fake accepted it. - New `TestListReadsTheRootMountsUnit`, built from the desktop's real unit names. Other systemctl calls are unchanged: they name only the module's own units, and `CheckMountpoint` refuses `/`, so none of those names starts with a dash. ## What I checked - Against unfixed code, `TestListReadsTheRootMountsUnit` failed with the desktop's note verbatim, and `TestList` failed (units missing, then a nil dereference in its own assertion). - With the fix: `go test ./...` and `go vet ./...` in modules/mounts pass; `checks/words` passes (none in 39400 strings). ## What I did not verify - I did not run the whole `merge-check.sh` locally; the required checks run it. - I did not see the fixed module on the desktop. After delivery, `node-mounts.list` on the desktop should answer no note and each mount with its unit state, and `/mnt/recalbox` with its automount. - The `systemctl show` output in the new test is written by hand from the listed units' states, not captured; only the unit names and the error are captured.
mesh-admin added 1 commit 2026-10-11 00:02:32 +00:00
mounts: pass unit names to systemctl show after --, so the root mount's -.mount is not read as an option
mesh/merge-gate pass: builds mounts → shanks; no bus step; every machine composes with the change as it did without (4 of 4 compose)
mesh/repo-check pass: its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)
mesh/delivery delivered
99df6b999b
systemctl refused the whole call on -.mount, and list answered every mount
without its unit state (novox/hq issue 374). The test fake now refuses a
dash-led argument as systemctl does, so it no longer agrees with the mistake.
Author
Contributor

Delivery novox/mesh-catalog@99df6b999bad — delivered since 2026-10-11T00:19:51Z

Delivery plan — builds mounts → shanks; no bus step

  • tier 0: mounts
  • shanks: receives mounts

Machines

  • mounts on shanks: passed — healthy 3 times over 3m39s
  • mounts on the rest running it: sent

Transitions

  • 2026-10-11 00:03 (new) → proposed (announced): novox/mesh-catalog#194's head announced
  • 2026-10-11 00:05 proposed → checked (checked): the verdict names this commit
  • 2026-10-11 00:05 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail
  • 2026-10-11 00:15 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move
  • 2026-10-11 00:15 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit
  • 2026-10-11 00:19 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says

The commit's note under refs/notes/mesh-plan keeps every transition: git log --notes=mesh-plan.

<!-- mesh-delivery:view --> **Delivery** `novox/mesh-catalog@99df6b999bad` — **delivered** since 2026-10-11T00:19:51Z **Delivery plan** — builds mounts → shanks; no bus step - tier 0: mounts - shanks: receives mounts **Machines** - mounts on shanks: passed — healthy 3 times over 3m39s - mounts on the rest running it: sent **Transitions** - 2026-10-11 00:03 (new) → proposed (announced): novox/mesh-catalog#194's head announced - 2026-10-11 00:05 proposed → checked (checked): the verdict names this commit - 2026-10-11 00:05 checked → ready (accepted): the gate passed or warned, and the repository's own check did not fail - 2026-10-11 00:15 ready → published (merged): on the trunk its modules follow: merged there, and its walk opened — or nothing for a walk to move - 2026-10-11 00:15 published → delivering (go): its walk started: let go by this owner in its group's order, by a person, or on the controller's own path — not a failed walk that carried a later commit for it, after which it waits for a walk of its own commit - 2026-10-11 00:19 delivering → delivered (done): its walk is done, carrying its own commit: every machine of its deploy plan passed, or was left as its policy says The commit's note under `refs/notes/mesh-plan` keeps every transition: `git log --notes=mesh-plan`.
Author
Contributor

Merge check at 99df6b99

  • mesh/merge-gate: PASS — every machine composes with the change as it did without (4 of 4 compose) (modules: mounts)
  • mesh/repo-check: PASS — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript)

Delivery plan — builds mounts → shanks; no bus step

  • tier 0: mounts
  • shanks: receives mounts
  • read by no module's build: modules/mounts/cmd/mounts/mounts_test.go

Run by the build seat on novox as build-1791676980750527226 (builds --log build-1791676980750527226).

--- the gate: mounts
mounts: ok, 3 tool(s), invokes seat:mesh-controller.data, keeps state shares, reads nfs-server.exports, ready: apply by unit every 30s; watch by its tool mounts_health every 1m0s; WARNING: config ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339)
long-running resources without health: 0
files asking for a setting without saying whether it is trusted: 1
1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here
judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-10T23:44:44Z says they run
composing every machine as the mesh is
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
composing every machine with the change
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued
merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose)
judged by controller development build against the facts of 2026-10-10T23:44:44Z

machines:
  - a machine (f35): composes
  - holds mesh-dns-resolver (idt): composes
  - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes
  - a machine (yvbpsm): composes

a merge would rebuild 1 module(s) in 1 tier(s): mounts

notes:
  - modules/mounts/cmd/mounts/mounts_test.go read by no module's build, and rebuild nothing (issue 280)
--- its merge-check.sh (go toolchain)
ok  	git.novox.be/novox/mesh-catalog/checks/words	0.003s
words: 12 retired words and 70 daemons' lines, none in the 39400 strings of 654 files
ok  	git.novox.be/novox/mesh-catalog/checks/agenthome	0.012s
agent-home: no archive and no file written into under the agent's home
ok  	git.novox.be/novox/mesh-catalog/checks/paths	0.005s
paths: no module names another's state on its machine (3 known, listed to go)
long-running resources without health: 69, as kept
testing modules/mounts
ok  	mounts/cmd/mounts	1.279s
--- its merge-check-typescript.sh (typescript toolchain)
**Merge check** at `99df6b99` - `mesh/merge-gate`: **PASS** — every machine composes with the change as it did without (4 of 4 compose) (modules: mounts) - `mesh/repo-check`: **PASS** — its merge-check.sh passed, each part in its toolchain: merge-check.sh (go), merge-check-typescript.sh (typescript) **Delivery plan** — builds mounts → shanks; no bus step - tier 0: mounts - shanks: receives mounts - read by no module's build: modules/mounts/cmd/mounts/mounts_test.go Run by the build seat on novox as `build-1791676980750527226` (`builds --log build-1791676980750527226`). ``` --- the gate: mounts mounts: ok, 3 tool(s), invokes seat:mesh-controller.data, keeps state shares, reads nfs-server.exports, ready: apply by unit every 30s; watch by its tool mounts_health every 1m0s; WARNING: config ask(s) for a setting and do(es) not say whether it is trusted, so it counts as trusted: set at the terminal alone; say "trusted" false where nothing trusts it (novox/hq issue 339) long-running resources without health: 0 files asking for a setting without saying whether it is trusted: 1 1 manifest(s) checked. Judged against the seats this binary carries; a claim on one of the mesh's own seats is judged fully at registration, and a seat declared by a module not given here reads as unknown. Identities judged on a 6-character machine name, against the bounds of the providers given here judging 0 module(s) changed against 4 machine(s), as the snapshot of 2026-10-10T23:44:44Z says they run composing every machine as the mesh is the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued composing every machine with the change the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued the bus's user list leaves out 5 user(s) the mesh has minted no credential for: controller, node.f35, node.idt, node.ygcyr, node.yvbpsm. Each is a user that cannot connect until one is issued merge gate: PASS — every machine composes with the change as it did without (4 of 4 compose) judged by controller development build against the facts of 2026-10-10T23:44:44Z machines: - a machine (f35): composes - holds mesh-dns-resolver (idt): composes - holds git, holds mesh-artifact-store, holds mesh-broker, holds mesh-catalog, holds mesh-delivery, holds mesh-dns-resolver, holds mesh-store, holds mesh-vault, holds npm-package-registry, the control node, the hub (ygcyr): composes - a machine (yvbpsm): composes a merge would rebuild 1 module(s) in 1 tier(s): mounts notes: - modules/mounts/cmd/mounts/mounts_test.go read by no module's build, and rebuild nothing (issue 280) --- its merge-check.sh (go toolchain) ok git.novox.be/novox/mesh-catalog/checks/words 0.003s words: 12 retired words and 70 daemons' lines, none in the 39400 strings of 654 files ok git.novox.be/novox/mesh-catalog/checks/agenthome 0.012s agent-home: no archive and no file written into under the agent's home ok git.novox.be/novox/mesh-catalog/checks/paths 0.005s paths: no module names another's state on its machine (3 known, listed to go) long-running resources without health: 69, as kept testing modules/mounts ok mounts/cmd/mounts 1.279s --- its merge-check-typescript.sh (typescript toolchain) ```
mesh-admin merged commit 372b6c2323 into main 2026-10-11 00:13:59 +00:00
mesh-admin deleted branch fix/374-mounts-list-reads-the-root-mounts-unit 2026-10-11 00:14:00 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: novox/mesh-catalog#194